GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add support for PostgreSQL by danbarua · Pull Request #2 · SQLStreamStore/SQLStreamStore

This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Conversation

@danbarua

@danbarua danbarua commented Jun 19, 2015

Copy link
Copy Markdown
Contributor

^ what that says

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
danbarua added 6 commits June 19, 2015 14:43
@danbarua
First stab at Postgres implementation
647bf80
@danbarua
Add SharedAssemblyInfo.cs
a9208b4
@danbarua
Compact json stub data
a8e7b44
@danbarua
Fix syntax for delete with expected version
c80de7a
@danbarua
Move logic to sprocs, where possible - read_all_forwards/backwards se…
7c2686f
…ems to hang when executed in a function, need to investigate.
@danbarua
Fix release build
aca368f
@danbarua

danbarua commented Jun 19, 2015

Copy link
Copy Markdown
Contributor Author

This uses the unstable build of Npgsql 3 - might have to do some fiddling around with Nuget .config to get it looking at the unstable feed source here: https://www.myget.org/F/npgsql-unstable

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danbarua added 8 commits June 22, 2015 09:25
@danbarua
Merge remote-tracking branch 'origin/append-other-scenarios' into pgsql
fdef276
Conflicts:
	src/Cedar.EventStore.Tests/EventStoreAcceptanceTests.DeleteStream.cs

Changed When_delete_stream_with_a_non_matching_expected_version_then_should_throw to include a couple of events in the stream, otherwise it tests deleting a non-existing stream.
@danbarua
Fix build errors after merge
5fd46f6
@danbarua
Use correct ordering when getting stream head
625e586
@danbarua
Fix merge
6235b70
@danbarua
Use json compatible stub data
1fe4a47
@danbarua
Make new pgsql tests pass
d6d344d
@danbarua
add .ncrunchproject files
8305a18
@danbarua
Add nuget.config to see if we can pull in npgsql from myget
b0e587a
@damianh

damianh commented Jul 15, 2015

Copy link
Copy Markdown
Member

@danbarua thanks for this! I've not forgotten it; just haven't had time lately for any oss stuff :(

I need CES, and I need Postgres support, so greatly appreciated :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@danbarua

danbarua commented Jul 15, 2015

Copy link
Copy Markdown
Contributor Author

I’m putting it into production in a month, kittens might die… or there will be a flurry of PRs while I work the issues out.

Dan Barua

On Wednesday, 15 July 2015 at 22:29, Damian Hickey wrote:

@danbarua (https://github.com/danbarua) thanks for this! I've not forgotten it; just haven't had time lately for any oss stuff :(
I need CES, and I need Postgres support, so greatly appreciated :)

—
Reply to this email directly or view it on GitHub (#2 (comment)).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danbarua added 13 commits July 16, 2015 11:15
@danbarua
Change PostgresEventStore ctor to take a connection string or connect…
15cc2bb
…ion string name (can't leak Npgsql types due to assembly versioning)

Change connection handling to create connection on-demand (issues with TPL + concurrency it seems) - lean on Npgsql connection pooling instead
@danbarua
Correct ordering for GetStream.sql
3af1d81
@danbarua
Include ordinal in ix_events_stream_id_internal_revision
6550a81
@danbarua
Optimization: When expected version passed in, filter for events > ex…
747973d
…pected_version to get current version.

If current_version is null then it's < expected version, if > expected_version then we don't have as many records to sort in order to find MAX(current_version)
If using ExpectedVersion.Any then it will have to sort through all of the events.
@danbarua
Optimize get_stream, subquery uses index more efficiently than join +…
c491bc3
… limit.

ExpectedVersion.Any should now perform as well as a given expected version.
@danbarua
Test coverage for non-existent stream read scenarios
be47314
@danbarua
Add failing test and implemenation in Postgres for end-of-stream chec…
9c3df31
…kpoints
@danbarua
Fixup test for reading past end of stream - GES may hand back an empt…
2e4a5dc
…y collection of events but will eventually return the end of the stream, with a checkpoint.
@danbarua
Add counter to short circuit run-away implementations
6d41c4e
@danbarua
Merge master
7166738
@danbarua
Make data + metadata proper JSON for postgres
99f17d4
@danbarua
Merge remote-tracking branch 'upstream/master' into pgsql
872d37f
@danbarua
Handle serializable transaction rollbacks as WrongExpectedVersionExce…
241f238
…ption
@danbarua
danbarua force-pushed the pgsql branch from 873fb87 to 241f238 Compare August 3, 2015 13:46
danbarua added 2 commits September 4, 2015 09:43
@danbarua
Create stream where not exists with ExpectedVersion.Any
3c77b39
@danbarua
Move tx.Commit() inside try block as exceptions are thrown at this point
35bc4db
@danbarua
danbarua force-pushed the pgsql branch from 2452559 to 35bc4db Compare September 8, 2015 16:07
@danbarua
Add support for buckets/schemas
9f271e6
@danbarua

danbarua commented Sep 18, 2015

Copy link
Copy Markdown
Contributor Author

Don't merge this just yet, some more wrinkles to iron out re: concurrency under heavy load.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danbarua added 2 commits October 8, 2015 14:23
@danbarua
Fixup tx serialization error handling - tx cannot be rolled back as i…
1f81789
…t has already been completed
@danbarua
Add concurrent load test
374162f
@danbarua

danbarua commented Oct 8, 2015

Copy link
Copy Markdown
Contributor Author

With that last commit, I'm going to monitor our error queues for a few days and fingers crossed we might be production-ready. :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danbarua added 5 commits October 8, 2015 15:40
@danbarua
Remove errant writer.close()
2854035
@danbarua
Move tx.commit() outside using() binaryImport block
f1a958a
@danbarua
Add try/catch for concurrency when creating a stream
176fb9f
@danbarua
include concurrency tests
c1f9e65
@danbarua
Fix #3 Use Npgsql 3.0.3 stable
e4649cc
damianh added a commit that referenced this pull request Nov 17, 2015
@damianh
Merge pull request #2 from danbarua/pgsql
5979614
Add support for PostgreSQL
@damianh
damianh merged commit 5979614 into SQLStreamStore:master Nov 17, 2015
damianh added a commit that referenced this pull request Oct 28, 2018
@damianh
Merge pull request #2 from thefringeninja/bugati fixed issue when set…
a2345f0
… stream metadata before appending
ArneSchoonvliet added a commit to ErazerBrecht/SQLStreamStore that referenced this pull request Apr 20, 2022
@ArneSchoonvliet Arne Schoonvliet
Upgrade nuget packages (SQLStreamStore#2)
c380e16
* Upgrade nuget packages

* Use correct version tavis

Co-authored-by: Arne Schoonvliet <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@danbarua @damianh
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.