GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test(patch): use get instead of the removed download alias by mikolalysenko · Pull Request #1600 · SocketDev/socket-cli

Conversation

@mikolalysenko

@mikolalysenko Mikola Lysenko (mikolalysenko) commented Oct 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

LLM Description written by Claude Code:claude-opus-5-5

Part of SocketDev/socket-patch#966 (v5 release blocker). Sibling PR: SocketDev/depscan#27676. This PR does not close the issue by itself; #966 closes once both PRs merge.

socket-patch v5 removes the download alias of get (SocketDev/socket-patch#966, implemented in SocketDev/socket-patch#1031). In v5 the old spelling is a usage error (exit 2).

test/integration/binary/js.test.mts ran socket patch download --dry-run ... express and accepted any exit code (toBeGreaterThanOrEqual(0)), so it could not catch a broken command. The test now:

  • runs socket patch get --dry-run --config {} express;
  • requires exit code 0;
  • requires the dry-run preview on stderr to show Arguments: get express, which proves cmd-patch forwards the right subcommand to socket-patch.

The new spelling also works with the socket-patch v2.0.0 binary this repo bundles today, because get is the primary command name in every version.

Testing: I did not run the integration suite locally, because pnpm install here fails on this checkout's pnpm and corepack settings. CI runs the test under RUN_INTEGRATION_TESTS.

🤖 Generated with Claude Code

Note

Low Risk
Test-only change with stricter assertions; no production code or runtime behavior is modified.

Overview
Updates the JS binary integration dry-run test to call socket patch get instead of the removed patch download alias (socket-patch v5 treats download as a usage error).

The test now requires exit code 0 (replacing a loose >= 0 check that could pass on failure) and asserts stderr includes Arguments: get express, so dry-run proves the patch subcommand forwards get correctly to socket-patch.

Reviewed by Cursor Bugbot for commit 115d9eb. Configure here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mikolalysenko
test(patch): use get instead of the removed download alias
115d9eb 
socket-patch v5 removes the `download` alias of `get`. Call
`patch get` in the dry-run integration test, and check that the
command exits 0 and forwards `get express` to socket-patch. The
old check accepted any exit code, so a usage error also passed.
@mikolalysenko Mikola Lysenko (mikolalysenko) mentioned this pull request Oct 9, 2026
Decide: warn on and then remove scan --apply/--vendor, and whether --vex stays embedded SocketDev/socket-patch#966
Closed
4 tasks
@jdalton

John-David Dalton (jdalton) commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Landed the test change on main in 90da6c6 through the repository delivery flow. The dry-run test now uses get, requires exit code 0, and checks the forwarded arguments. This test belongs to main; v1.x does not contain this test file. CI verification remains pending.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jdalton John-David Dalton (jdalton) closed this Oct 11, 2026
@jdalton
John-David Dalton (jdalton) deleted the socket-patch-v5-migrate-download branch November 9, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mikolalysenko @jdalton
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.