GeezerVison

v5 drops these legacy spellings outright, with no warning release:

- scan --apply (use --mode agent) and scan --vendor (use --mode vendored).
  resolve_mode_flags loses its cross-mode boolean arms; the only conflict
  left is --sync with a --mode other than agent.
- get --no-apply (use --save-only; SOCKET_SAVE_ONLY is unchanged).
- the `download` alias for get and the `gc` alias for repair.

Each removed spelling is now an ordinary clap usage error (exit 2).
--sync stays as the shorthand for --mode agent --prune. Comments that
named the old flags now name the --mode spelling.

Part of #966.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

Tests now pass --mode agent / --mode vendored instead of --apply /
--vendor, --save-only instead of --no-apply, and set ScanArgs.mode
instead of the deleted apply/vendor fields. The boolean conflict tests
become --mode X --sync conflict tests, the alias tests now assert that
the old spellings fail to parse, and cli_parse_main gains a table test
that checks every removed spelling is a usage error, in the parser and
through the binary (exit 2).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

CLI_CONTRACT.md no longer promises scan --apply/--vendor, get --no-apply
or the download/gc aliases; it uses the --mode spelling throughout and
notes the removal. migrating-to-v5.md lists each removed spelling with
its replacement.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

The exit-2 row of the contract still described scan's cross-mode
conflict as a --mode next to another mode's boolean spelling; only
--sync with a non-agent --mode is left. Four test labels and comments
still read "scan --vendor", and two comments still called the removed
spellings deprecated or legacy.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

Resolve vendor_flow.rs: keep main's gem takeover preview refusals in the
scan --mode vendored dry-run arm, with the PR's comment wording (no
reference to the removed `--apply` spelling).

Co-Authored-By: Claude <[email protected]>

Resolves the CLI_CONTRACT.md get/remove rows: keep this branch's get
row without the removed --no-apply alias and take main's remove row.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

…ove-legacy-spellings

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LD4qUfZKhg2qgt3x9vGeFf

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Resolve two CLI_CONTRACT.md conflicts by keeping main's new text (the
atomic vendored-to-hosted takeover wording from #1039 and the
gem_lock_unsupported warning from #768) while re-applying this PR's
migration away from the removed spellings: `scan --apply` becomes
`scan --mode agent`, and `--apply`/`--vendor` in the lockfile
supplement become agent mode / vendored mode.

Co-Authored-By: Claude <[email protected]>

The branch was updated in parallel with a merge of an older main
(3b4ac84). This merge reconciles it with the merge of main at 823810a;
the resulting tree is unchanged from that merge.

Co-Authored-By: Claude <[email protected]>

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

…ove-legacy-spellings

# Conflicts:
#	docs/migrating-to-v5.md

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

…ove-legacy-spellings

# Conflicts:
#	crates/socket-patch-cli/CLI_CONTRACT.md

Resolve conflicts with #1027 (--json usage errors print coded errors):
keep this branch's --sync-only cross-mode wording (the legacy mode
booleans are removed here) and add main's note that --json usage errors
now print the coded error on stdout, in scan/mod.rs and CLI_CONTRACT.md.

Co-Authored-By: Claude <[email protected]>

cursor Bot left a comment