GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Fix path-scoped scan missing member alias links (#1266) by mikolalysenko · Pull Request #1470 · SocketDev/socket-patch

Conversation

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

LLM Description written by Claude Code:claude-opus-5-5

Fixes #1266

What users saw

In a workspace using pnpm's default isolated linker, or npm with
install-strategy=linked, a member that depends on an alias
("lp": "npm:[email protected]") gets packages/a/node_modules/lp as a
symlink into the root store:

scan --mode agent packages/a never selected left-pad, so the copy
member a loads stayed unpatched. It reported success and exited 0.
rollback packages/a left the patched bytes in place (npm: success;
pnpm: exit 1 path_glob_no_match).

The member's plain-name links (packages/a/node_modules/ms) worked.

Root cause

Path-scoped scan and rollback match patterns against the paths
find_all_packages_for_rollback_reusing returns, which are the npm
crawler's copies. The crawler records a plain-name link at the member
path, but never takes an alias link as a copy. That rule is
deliberate (#856): apply and VEX must see each physical copy once, and
the vex_consumed tests pin it. Path scoping asks a different question:
which install paths reach the package.

Fix

A new `find_package_paths_for_path_scope` (used only by `scan`'s and
`rollback`'s path targets) returns the physical copies plus every
package link directly in a `node_modules` root (scoped ones one level
down) whose target's own `package.json` name@version is one of the
requested npm purls. Links are matched by identity in one pass over the
root links, so a member alias pointing at a store peer variant the crawl
skipped still counts. Apply, VEX and rollback's restore list are
unchanged. `CLI_CONTRACT.md` ("Path-scoped scans") now describes this.

A first attempt changed the crawler instead. It broke the #856
`vex_consumed` invariants, so I dropped it. A second version
(84b3690) expanded store peer variants once per purl. Review measured
it as quadratic on big pnpm stores, and 4288a72 replaces it:

`scan packages/a --mode agent --dry-run`, debug build	main	`84b3690`	`4288a72`
pnpm store, 1,000 entries	0.10 s (review)	4.7 s	0.10 s
pnpm store, 3,000 entries	0.24 s (review)	34.6 s	0.24 s

Tests (red on main, green here)

Issue shape	Test
#1266 pnpm isolated, scoped scan	`scan::scan_paths_e2e::paths_scope_selects_pnpm_member_alias_link`
#1266 npm linked (npm 11+ and npm 10 store-entry spellings), scoped scan	`scan::scan_paths_e2e::paths_scope_selects_npm_linked_member_alias_link`
#1266 member alias resolving to a different pnpm peer variant	`scan::scan_paths_e2e::paths_scope_selects_member_alias_link_to_a_peer_variant`
#1266 `rollback packages/a` (pnpm `.pnpm` and npm `.store`)	`rollback::rollback_duality_invariants::path_scoped_rollback_selects_member_alias_link`

Without the fix, the scan tests fail with a batch body of only
{"components":[{"purl":"pkg:npm/[email protected]"}]}, and the rollback test
fails on the exit code. The peer-variant test also fails if the
variant expansion is removed.

Local runs:

cargo fmt --all -- --check: clean
cargo clippy --workspace --all-features -- -D warnings: clean
cargo test --workspace --all-features --no-fail-fast: everything
passes except 13 tests that also can't pass in this sandbox on
main. Most are write-failure tests that need chmod-denied writes,
and the sandbox runs as root. One bun lockb test needs network access
to patches-api.socket.dev. None of them touch path scoping, and the
core crate is unchanged.

/code-review high found 6 issues and all of them are fixed in
84b3690: the peer-variant gap, moving the link pass out of rollback's
restore resolver, skipping the root clone when there are no npm purls,
no panic on a join error, Ecosystem::from_purl in place of a prefix
test, and folding a duplicate test scan into the loop.

🤖 Generated with Claude Code

https://claude.ai/code/session_011KEL5sGU2JuwHvDCpJtMwi

Generated by Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Start fix for #1266

6f2d2dc

Assisted-by: Claude Code:claude-opus-5-5

Mikola Lysenko (mikolalysenko) mentioned this pull request

Oct 13, 2026

Path-scoped agent scan packages/a and rollback packages/a skip a workspace member's npm alias (lp@npm:left-pad) under install-strategy=linked, while its plain links are in scope (exit 0, success) #1266

Closed


          Scope member alias links in path-scoped runs

88c91ff

Under pnpm's default isolated linker and npm's linked install
strategy, a workspace member's alias dependency ("lp":
"npm:[email protected]") is a symlink from packages/a/node_modules/lp
into the root store. `scan --mode agent packages/a` never selected it
and `rollback packages/a` never restored it, both reporting success,
while the member's plain-name links were handled.

Path scoping now also counts every package link in a node_modules
root that resolves to one of a package's installed copies. The
crawler itself still records only physical copies, so apply and VEX
see each copy once, as before.

Fixes #1266

Assisted-by: Claude Code:claude-opus-5-5

Mikola Lysenko (mikolalysenko) force-pushed the agent/fix-path-scope-alias-links branch from ac8b66c to 88c91ff Compare

October 13, 2026 07:56

Mikola Lysenko (mikolalysenko) mentioned this pull request

Oct 13, 2026

Swarm health manager log #1382

Open


          Keep alias links out of rollback's copy list

84b3690

The link pass lived in the resolver rollback also restores from, so
every rollback did extra filesystem work it then threw away. It now
runs only for scan and rollback path targets, in its own lookup.

A member's alias link can also point at a pnpm peer variant the crawl
skipped once it found the root's copy, so store peer variants now
count when matching links. A failed link enumeration falls back to
the plain copies instead of aborting the run.

Assisted-by: Claude Code:claude-opus-5-5

Mikola Lysenko (mikolalysenko) marked this pull request as ready for review

October 13, 2026 08:25

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Copy link

Copy Markdown

Collaborator Author

BugBot review

Generated by Claude Code

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1 similar comment

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Copy link

Copy Markdown

Collaborator Author

BugBot review

Generated by Claude Code

cursor[bot] reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cursor Bot reviewed

Oct 13, 2026

View reviewed changes

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Mikola Lysenko (mikolalysenko) added the Ready for review Agent-verified: mergeable, CI green, Bugbot clean — awaiting human review label

Oct 13, 2026

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Copy link

Copy Markdown

Collaborator Author

Labeled Ready for review by the burn-down agent.

Head: 84b3690169 (mergeable against main, no conflicts; CHANGELOG.md untouched)
CI: 36/36 green + 50 path-skipped; no main-wide failures
Bugbot: reviewed 84b3690, no new issues; no open review threads
Reviewer focus: how path-scoped scan/rollback <member> now pick up workspace member alias links (ecosystem_dispatch.rs, scan/mod.rs) and the new scan_paths_e2e.rs / rollback duality cases.
Slack announcement not sent: the Slack send tool isn't available to this run.

Generated by Claude Code

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Copy link

Copy Markdown

Collaborator Author

Final review: blocking perf regression on path-scoped `scan`

The fix is correct: the 4 new tests pass on this head and fail on the merge-base. However, it makes path-scoped scan on a pnpm store scale as O(crawled purls × store entries), so I can't brief it for approval yet.

Cause

In scan, scan/mod.rs:2183 calls the new find_package_paths_for_path_scope for every crawled purl that isn't directly in scope. In a monorepo that is almost the whole install.
For each npm purl, ecosystem_dispatch.rs:667 runs with_store_peer_variant_copies. Each call builds a fresh scanned set, re-lists the whole .pnpm/.store/.vlt store, stats each entry's node_modules and probes the ancestors.
Before this PR, the scoped path did a single dispatch_find.

Measured with debug builds on a synthetic pnpm root: N store entries, root links to each, and member packages/a with one link. Command: scan packages/a --mode agent --dry-run --json.

Store entries	merge-base	this head
1,000	0.10 s	6.9 s
3,000	0.24 s	53 s

Unscoped scan on this head stays at 0.16 s for N=3,000. Release builds are faster but still quadratic, so a store of about 5,000 entries would take minutes.

Suggested fix (any one)

Enumerate the node_modules root links once, canonicalize each, read the target's package.json name@version, and match it against the unresolved purls. This avoids per-purl variant expansion.
Or expand variants only for purls with a link target that matched no known copy.
Or share one scanned set and one store listing across all purls.
A large-store regression test or bench would keep this from coming back.

Non-blocking

Root node_modules links now select too (e.g. node_modules/left-pad). That fits the semantics, but the CLI_CONTRACT.md clause only describes member aliases.
The new tests are all #[cfg(unix)].
find_all_packages_for_rollback_reusing may have no non-test caller left.

Question for a human: is the scoped-scan slowdown acceptable to ship, or should this wait for one of the fixes above? I recommend the fix. I've labelled this agent:needs-human and removed Ready for review; whoever picks it up can drop the label once it's fixed.

Generated by Claude Code

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mikola Lysenko (mikolalysenko) added agent:needs-human and removed Ready for review Agent-verified: mergeable, CI green, Bugbot clean — awaiting human review labels

Oct 13, 2026


          Keep scoped scans fast on large pnpm stores

4288a72

The previous commit matched member links by expanding every crawled
npm purl's store peer variants, re-listing the whole store once per
purl. A path-scoped scan of a 3,000-entry pnpm store went from 0.24s
to 35s (debug build).

Links in each node_modules root are now matched by their target's
own package.json name@version, in one pass however many purls are
asked for. The same 3,000-entry scan takes 0.24s again, and a link to
a peer variant the crawl skipped still counts.

Assisted-by: Claude Code:claude-opus-5-5

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Copy link

Copy Markdown

Collaborator Author

[agent] Thanks, the regression was real. Fixed in 4288a72.

Path scoping no longer expands peer variants per purl. It enumerates the node_modules root links once, canonicalizes each, reads the target's package.json name@version and matches it against the requested npm purls (your first suggestion). A link to a peer variant the crawl skipped still counts. The peer-variant regression test still passes.
Same synthetic pnpm root as yours (N store entries, root links to each, packages/a with one alias link), debug build, scan packages/a --mode agent --dry-run --json:

Store entries	`84b3690`	`4288a72`
1,000	4.7 s	0.10 s
3,000	34.6 s	0.24 s

Both select the same single package. 4288a72 matches your merge-base numbers.

Non-blocking: CLI_CONTRACT.md now describes any root link, matched by its target's identity, not only member aliases. The tests stay #[cfg(unix)] because they create symlinks; the other symlink path-scope test in this suite is unix-only for the same reason. find_all_packages_for_rollback_reusing keeps its test callers (the snapshot-equivalence tests), so I left it in place.
I didn't add a timing-based large-store test because it would be flaky on CI runners. The bench above is easy to rerun if you want one as a follow-up.

I'm removing agent:needs-human as your note says to once this is fixed.

Generated by Claude Code

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mikola Lysenko (mikolalysenko) removed the agent:needs-human label

Oct 13, 2026

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Copy link

Copy Markdown

Collaborator Author

BugBot review

Generated by Claude Code

cursor[bot] reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cursor Bot reviewed

Oct 13, 2026

View reviewed changes

cursor Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 4288a72. Configure here.}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Mikola Lysenko (mikolalysenko) added the Ready for review Agent-verified: mergeable, CI green, Bugbot clean — awaiting human review label

Oct 13, 2026

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Copy link

Copy Markdown

Collaborator Author

Labeled Ready for review by the burn-down agent.

Head: 4288a72bbd18bb6e59cc7eb620b2a37ad7dabbc9 (mergeable against main, no conflicts; no CHANGELOG.md change)
CI: 35/35 green (19 skipped) on the head, no main-wide failures
Bugbot: reviewed 4288a72, no new issues; no unresolved review threads
Reviewer note: the earlier final-review perf regression on path-scoped scan was addressed in 4288a72 (no longer expands peer variants per purl).
Slack announcement not sent this run (Slack send tool unavailable); the next run will retry.

Generated by Claude Code

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Copy link

Copy Markdown

Collaborator Author

Final review brief

What it does: Path-scoped scan (agent mode) and rollback decided scope from the crawler's list of physical copies, which on purpose leaves out npm alias links. So a member's node_modules/lp -> npm:[email protected] link into the pnpm or npm-linked store was never in that member's scope. The new find_package_paths_for_path_scope adds every link at the top of each node_modules root (and under @scope dirs) whose target's package.json name@version is a requested purl. Scan and rollback use it only to decide which purls are in scope.

Risk: low. It only adds match candidates for path-scoped runs. Writes still go through the crawled copies, so it can't touch anything an unscoped run wouldn't. Links are followed read-only (canonicalize plus a package.json read).

Look here

ecosystem_dispatch.rs:680: which roots get searched (reuses the earlier crawl's roots, skipped when no npm purls are requested)
ecosystem_dispatch.rs:733: identity, where links are followed
ecosystem_dispatch.rs:752: link enumeration, including scoped and hidden entries
rollback.rs:1594 and scan/mod.rs:2183: the two call sites

Verified

Read the full diff.
Test binaries pass: scan 128/128, rollback 58/58, and the ecosystem_dispatch unit tests 46/46.
With src/ reverted to main, all 4 new tests fail, so they do test the fix.
A throwaway probe with a self-loop link, a dangling link and a scoped link pointing outside the project: no hang and no error. Broken links are skipped.
Clippy is clean on the changed crate's lib and bins.
CHANGELOG.md is untouched and there's no debug code.
CI is green on this head (ci-ok, clippy). Bugbot reviewed this head and left no open threads.
I didn't re-measure the perf table, but the link pass is one walk per root and doesn't depend on how many purls are requested, which fits the claim.

Changes I made: none.

Open questions (non-blocking)

CLI_CONTRACT.md:213 still says path matching uses "no filesystem access or symlink resolution". The glob match itself doesn't, but which purl a link belongs to is now decided by resolving the link. That clause could say so.
All the new tests are #[cfg(unix)]. Windows junctions should be found, since is_symlink is true for them, but no test covers it.
If a member links a workspace sibling whose name@version matches a registry package, that purl is selected. main already does this for plain-name links, so it isn't a regression.

Auto-merge is armed, so approving sends this straight to the merge queue.

Generated by Claude Code

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mikola Lysenko (mikolalysenko) enabled auto-merge

October 13, 2026 12:07

Tanmay Singla (Tanmay182003) approved these changes

Oct 13, 2026

View reviewed changes

Mikola Lysenko (mikolalysenko) added this pull request to the merge queue

Oct 13, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks

Oct 13, 2026

Uh oh!

There was an error while loading. Please reload this page.

Mikola Lysenko (mikolalysenko) added this pull request to the merge queue

Oct 13, 2026

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Copy link

Copy Markdown

Collaborator Author

Final reviewer: re-enqueued once. The merge group's coverage job failed in patch::redirect::upstream::npm::tests::project_registry_decides_a_mirrors_tarball_urls (npm.rs:4072). That test is on main (added in #1466) and isn't touched by this PR. It reads SOCKET_NPM_REGISTRY, which the bun_lockb.rs tests set in the same lib test binary, so the two race when they run in parallel. It passes in isolation on main. The owner has been told; a fix belongs in its own PR.

Generated by Claude Code

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Merged via the queue into main with commit f6bd5c4

Oct 13, 2026

54 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Mikola Lysenko (mikolalysenko) deleted the agent/fix-path-scope-alias-links branch

October 13, 2026 14:23

Mikola Lysenko (mikolalysenko) mentioned this pull request

Oct 13, 2026

Fix flaky npm mirror tarball test #1487

Closed

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Copy link

Copy Markdown

Collaborator Author

[agent] Dequeued on coverage (merge-queue run 38408989500). The failing test, patch::redirect::upstream::npm::tests::project_registry_decides_a_mirrors_tarball_urls, is not this PR's: #1470 doesn't touch socket-patch-core, and the queue branch's core crate is identical to main. The test came in with #1466. It reads SOCKET_NPM_REGISTRY, which the serial bun lockb and vlt tests set to a mock server, but the test itself wasn't serial. With the variable set, it fails on the same line (npm.rs:4072) every time.

The fix is #1487: it marks the test #[serial_test::serial]. Once that merges, this PR can be re-queued as is. I'm not pushing it into this branch, so the approval here isn't reset.

Generated by Claude Code

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mikola Lysenko (mikolalysenko) added a commit that referenced this pull request

Oct 13, 2026


          chore(release): 5.0.1 notes for PRs merged since the cut

0b23ce5

Covers #1469, #1470, #1474, #1475, #1478, #1479, #1480 and #1482; #1484 is
CI-only. The notes now cover main through 285a5e8.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

github-merge-queue Bot pushed a commit that referenced this pull request

Oct 13, 2026


          chore(release): 5.0.1 (#1485)

2e0a6b9

* ci(release): publish npm from release.yml, not publish-npm.yml

Every socket-patch npm package's trusted publisher is registered against
release.yml, and npm allows only one publisher per package. The 5.0.0
release dispatched publish-npm.yml, whose OIDC token named that file, so
npm rejected it with E401 before staging anything.

Move the npm leg back inline as release.yml's npm-publish job (same steps
as publish-npm.yml) and delete publish-npm.yml, so the existing
registration keeps working. Add an `npm-retry-version` input that skips
the version gate, build, tag, GitHub release and crates.io jobs and
re-stages npm from an existing release's assets; this retries 5.0.0 now
and replaces the manual Publish npm dispatch. crates.io stays dispatched
through publish-cargo.yml, since crates.io allows several publishers per
crate.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

* chore(release): fold 22 more PRs into the 5.0.0 notes

Cover the PRs merged to main after #1432's base (1779317..4cb3643):
Cargo source replacement and registry = "crates-io" (#338/#455, #386),
pnpm lockfile=false (#1074), berry removed descriptors (#1435), yarnrc
${VAR} reads (#1100), CRLF .npmrc append (#1196), Composer vendor-dir
cascade and global home (#439/#686, #586), Go +incompatible vex (#484),
gem moved BUNDLE_GEMFILE and commented Gemfile revert (#952, #988),
Poetry source = "pypi" (#1282) and Hatch path characters (#547).

No entries for #1411 (macOS fix to code #1393 added in this release;
the #1393 entry already describes the intended behavior), #1426 (perf
regression introduced and fixed within 5.0.0) or the CI/test/bench PRs.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

* chore(release): cover #1419, #1434, #1440, #1442, #1444 in the 5.0.0 notes

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

* chore(release): 5.0.1

Cut [Unreleased] into [5.0.1] — 2026-10-13 and stamp 5.0.1 with
scripts/version-sync.sh. The 5.0.1 notes cover main through 501c6d9
(#1449), i.e. every PR after the v5.0.0 tag (6ad6add): the npm
publish fix (5.0.0 never reached npm or crates.io, 5.0.1 is the first
v5 there), #1465, #759, #1460, #1462, #1445, #869, #1447, #1450,
#1467, and #1449 under Maintenance. CI/test-only PRs (#1448, #1452,
#1454, #1457, #1459) have no entries.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

* chore(release): 5.0.1 notes for PRs merged since the cut

Covers #1469, #1470, #1474, #1475, #1478, #1479, #1480 and #1482; #1484 is
CI-only. The notes now cover main through 285a5e8.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>

This was referenced Oct 13, 2026

CI performance dashboard #1182

Open

Agent-mode scan run from a vlt (or pnpm) workspace member fails package_not_installed for the member's npm-alias dependency, while the same alias patches from the root #1494

Closed

Fix npm alias links missed from a member (#1494) #1500

Merged

Mikola Lysenko (mikolalysenko) pushed a commit that referenced this pull request

Oct 13, 2026


          Patch npm alias links from a workspace member

0a81315

Run from inside a vlt, pnpm or npm-linked workspace member, apply
reported a member's npm alias dependency ("lp": "npm:[email protected]")
as package_not_installed and exited 1, and rollback could not restore
it, although scan had offered the patch. The member's node_modules is
the only root walked there, and its alias entry is only a link into
the root store, which the resolver never takes as a copy.

Apply's and rollback's lookups now add the root links whose target is
a requested package, the same pass path scoping got in #1470. Both
commands already act on each physical copy once, so a run from the
root still patches the store copy a single time.

Fixes #1494

Assisted-by: Claude Code:claude-opus-5-5

Reviewers

cursor[bot]

cursor[bot] left review comments

Tanmay Singla (Tanmay182003)

Tanmay182003 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Ready for review

Agent-verified: mergeable, CI green, Bugbot clean — awaiting human review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

LLM Description written by Claude Code:claude-opus-5-5

What users saw

Root cause

Fix

Tests (red on main, green here)

Uh oh!

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Uh oh!

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Uh oh!

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Final review: blocking perf regression on path-scoped scan

Uh oh!

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Uh oh!

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Uh oh!

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Final review brief

Uh oh!

Uh oh!

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Uh oh!

Uh oh!

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Final review: blocking perf regression on path-scoped `scan`