GeezerVison

LLM Description written by Claude Code:claude-opus-5-5

Fixes #1941

Summary

Nine suites of the apply test binary each wrote their own manifest, blob, npm-package, gem and event-lookup helpers beside apply_fixture's (register row T51, Part 5 of the living document). They now build every fixture through apply_fixture, and the event-by-purl lookup lives in common/envelope.rs. The PR changes only tests; there is no product code in it.

Changes

• apply_fixture.rs
  • New hashed_file (one_file from hashes) and index_js_patches (one package/index.js record per purl).
  • link_dir moved here from the two global-store suites.
  • run_gem: run_with_env's env plus the BUNDLE_* scrub. run_gem_apply is built on it.
  • stage_blob writes through common::write_blob.
• common/envelope.rs: new event_for(envelope, purl), replacing 4 identical private event fns.
• Local copies deleted:
  • apply_network.rs: write_npm_package, write_root_package_json, write_manifest_with_patch and 8 hand-staged blobs.
  • apply_invariants.rs: MANIFEST_JSON, two hand-formatted manifests, dir_hash + collect_files (the file already had snapshot_dir), and its private run_apply.
  • bun_global_store.rs, pnpm_global_virtual_store.rs: link_dir, write_manifest, event.
  • cargo_lock_source.rs, check_verifies_installed_tree.rs, lockfile_only_skip.rs: write_manifest/record/project writers, install_npm_pkg, run_apply, run_cargo_apply, store_after_blob, event.
  • gem_stale_bundler_plugin.rs, in_process_gem_config_warning.rs, in_process_gem_fallback_home.rs: their hand-formatted rack manifests and runners.
• Moved: the fallback-home human-warning test goes from apply_render.rs into in_process_gem_fallback_home.rs, where it reuses that file's fixture. Its assertions are unchanged.
• gem_stale_bundler_plugin's child now gets the Extra::Bundle scrub, as the issue asks.
• 13 explicit SOCKET_TELEMETRY_DISABLED=1 pairs dropped: hermetic::command forces that value already. apply_network's =0 opt-in stays.
• Tests changed:
  • apply_does_not_mutate_socket_dir_offline and apply_does_not_mutate_socket_dir_when_no_packages_match now compare .socket/ path→bytes snapshots. They used to compare a digest and then re-check two files ("belt-and-suspenders against a dir_hash blind spot"); the snapshot has no such blind spot. Red→green: writing one byte into the sentinel after the run fails the test at the snapshot assert.
  • All other assertions are unchanged.
  • Test count is 157 before and after.

Size

git diff --stat: 13 files, +410 / −1,045, all of it test code. Production lines: 0.

Behavior change

None in the product. In the tests:

• Gem children now also get jvm_env::isolate_cli (stand-in HOME), as every run_with_env child already does.
• apply_invariants' children get the same isolation through run_apply.
• Record descriptions and exportedAt are now the fixture's.
• Fixtures that had no .socket/blobs/ dir now get an empty one.

/code-review high

It reported 10 findings; I fixed 9:

• The gem suites that pin --cwd (config_warning, fallback_home) run from the runner's dir again.
• apply_invariants uses the shared run_apply.
• store_after_blob was replaced by stage_blob.
• The specifications dir is now derived from install_gem's path.
• write_patches copies were merged into index_js_patches.
• apply_network uses one_file.
• Two stale docs were fixed.

I did not fix one: "run_gem copies run_bin_with_env's body to insert the scrub." The fix would add an extras parameter to common::run_bin_with_env, which has 100+ callers across binaries. That belongs to T55/#1089, not this PR.

Not done from the issue: step 3's single manifest writer (write_manifest on top of common::write_minimal_manifest). That writer takes one purl and has 100+ callers in other binaries, so giving it a records parameter goes beyond this binary. Only stage_blob was unified.

Verification

• cargo test -p socket-patch-cli --test apply: 157 passed.
• Clippy reports nothing in the touched files. The existing test-target lints in vlt_hosted_common/prebuilt_common are untouched, and CI's clippy does not lint tests.

CI

79 of 81 checks and Bugbot are green. hosted-e2e (and the ci-ok aggregate) is red: e2e_hosted_production::bun_hosted_install_proof gets a 403 from the live patch.socket.dev for minimist-1.2.2.tgz, on 3 attempts in each of two runs. That test binary is not in this diff, and the same check passed on #1939 at 15:12Z.

Risk

Low: tests only.

https://claude.ai/code/session_011f9aeSfw2PKstyBdKzjUFz

Generated by Claude Code