GeezerVison

LLM Description written by Claude Code:claude-opus-5-5

Fixes #1965

Summary

When the root package.json overrides a registry range with a remote tarball URL, git or path spec, npm installs that spec and ignores the lock's resolved. Hosted and vendored scans now treat that copy like any other non-registry install. Hosted skips it with redirect_npm_non_registry_entry_skipped, vendored refuses it (vendor_lock_entry_not_rewritable), and VEX lockfile discovery attests nothing for it. Before this change, both modes rewired the copy and exited 0, npm ci then installed the unpatched upstream bytes, and vendored vex / vendor --check and the hosted in-run --vex still attested the patch.

Root cause

npm_non_registry_entries (crates/socket-patch-core/src/vendor/npm_origin.rs) skipped every edge whose declared spec is a registry spec before looking at overrides. It only handled the opposite direction (#490: a git/URL spec that an override turns into a registry one). A remote-tarball override also gets past the resolved check, because its resolved is an ordinary https://…tgz. The hosted rewriter, the vendored lock writer and VEX discovery all read this one function, so every mode was affected.

Fix

• NpmOverrides::non_registry_replacement: for a registry-spec edge, returns the non-registry spec an override makes npm install. When the winning rule is decided exactly, its value counts. When it isn't decided (a target selector other than the spec, a range selector on an ancestor, or equally close rules that disagree), any rule for the package with a non-registry value counts. That follows the module's existing rule for unclear cases: leave the copy unpatched and reported, never attest it. dependent_chain now starts a dependent inside a workspace member with that member (named by its name field, else its root-level link entry, else its folder with any @scope/ parent), because npm reaches members through the root's link edge and applies member-scoped rules to them (this also makes the npm hosted and vendored modes refuse a registry-installed package when its dependent's git spec is replaced by an overrides entry (regression from #345) #490 direction recognize member-scoped registry overrides). A fast path returns early when no rule for the package names a non-registry spec, so locks with unrelated overrides don't pay a per-edge chain walk.
• npm_override_only_entries: lists the entries flagged only because of such an override. VEX discovery keeps a Socket pin at one of those entries shadowed, not foreign, so rollback / remove can still unwind a pin that a release before this fix wrote there. Without this, those projects would be left with a hosted pin nothing unwinds.
• No wrapper changes (npm/, pypi/, gem/ only dispatch to the binary).

Tests (red → green)

Every new test fails with the fix neutralized (non_registry_replacement forced to None) and passes with it:

Per-issue checklist

• npm hosted and vendored scans pin a dependency that overrides forces to a remote tarball URL; npm ci installs it unpatched, and vendored vex / vendor --check still pass #1965 hosted: patch::redirect::tests::issue_1965_…, e2e_redirect_npm_build::npm_redirect_skips_a_registry_edge_overridden_to_a_url
• npm hosted and vendored scans pin a dependency that overrides forces to a remote tarball URL; npm ci installs it unpatched, and vendored vex / vendor --check still pass #1965 vendored: vendor::npm_lock::tests::issue_1965_…
• npm hosted and vendored scans pin a dependency that overrides forces to a remote tarball URL; npm ci installs it unpatched, and vendored vex / vendor --check still pass #1965 vex / vendor --check attestation: vex::discover::npm::tests::issue_1965_…
• npm 8 (lockfileVersion 2) / 10 / 12 (allow-remote=all): the logic reads packages only (lockfileVersion ≥ 2) and doesn't depend on the npm version. The e2e runs on whatever npm the CI matrix leg pins.

Local verification

• cargo fmt --all -- --check: ok
• cargo clippy --workspace --all-features -- -D warnings: ok
• cargo test --workspace --all-features --no-fail-fast: everything passes except 11 tests that fail for environmental reasons, all in code this PR doesn't touch. The sandbox runs as root, so 9 chmod/unremovable write-failure tests can't make writes fail (in_process_redirect ×3, repair ×2, core copy_tree / vlt_heal / pypi_poetry / pypi_requirements). The other 2 (e2e_bun_lockb) fetch blobs from the live patches-api.socket.dev, which the sandbox can't reach (see Fix bun.lockb nightly e2e reaching the live blob API #1905). CI runs as non-root.
• SOCKET_PATCH_NPM_E2E_REQUIRED=1 cargo test -p socket-patch-cli --all-features --test e2e_redirect_npm_build -- --ignored npm_redirect_skips_a_registry_edge_overridden_to_a_url: ok (npm 10.9.9)

Generated by Claude Code