GeezerVison

bugbot run

Generated by Claude Code

PR Summary

Low Risk
Refactor preserves production wiring; changes are mainly test isolation and dependency injection with no new runtime paths.

Overview
Unit tests no longer depend on the host’s Yarn setup (YARN_NODE_LINKER, ~/.yarnrc.yml, ancestor rc files). Production behavior is unchanged: detect_npm_pkg_manager and live_pnp_marker delegate to internal *_with / live_pnp_marker_in helpers that take an injectable nodeLinker closure (still wired to yarn_node_linker at the public API).

Tests use detect_npm_pkg_manager_hermetic and YarnPnpLoader::detect_hermetic, which resolve linker only from the project’s own .yarnrc.yml via YarnEnv::repository_only(). Existing pkg_managers and pnpm_layout assertions are switched to these entry points.

New coverage confirms public vs hermetic agreement when no PnP loader exists (linker lookup not invoked), and that hermetic detection ignores rc files above the temp project root.

^{Reviewed by Cursor Bugbot for commit 2abfc1e. Configure here.}

bugbot run

Generated by Claude Code

Ready for review at 2abfc1e.

• CI: 50/50 checks done, none failed (31 success, 19 skipped by path filters). No main-wide failures.
• Bugbot: reviewed 2abfc1e and found nothing.
• /code-review high: one real gap, fixed in 2abfc1e. The hermetic helper still walked ancestor .yarnrc.yml files, and outside a git checkout that walk has no bound. It now reads only the project's own rc file, and there is a regression test for it. The other findings are scope follow-ups for Crawler unit tests read the developer's real HOME, YARN_NODE_LINKER and VIRTUAL_ENV: 12 pkg_managers/pnpm_layout tests fail under a user nodeLinker setting #1919 or predate this PR. They are listed in the PR description.
• Worth a reviewer's look: whether #[cfg(test)] *_hermetic twins are the right shape, or whether a single test-time override in YarnEnv would be better as the follow-up.

Generated by Claude Code

Final review brief

What it does. Unit tests for the npm package-manager detector no longer pick up the host's yarn setup (YARN_NODE_LINKER, ~/.yarnrc.yml, rc files above the project). The public detectors now hand the nodeLinker lookup to internal *_with helpers. Production still passes the same yarn_node_linker(scope, root), and tests pass a #[cfg(test)] lookup that reads only the project's own .yarnrc.yml. Test-only otherwise. Every changed test asserts the same thing on the same fixtures.

Risk: low. The production paths are a straight delegation with the same closure, and the new code is #[cfg(test)] only. The one behavioural nuance is that YarnPnpLoader::detect now computes the manager before calling detect_with, which is the same order as before.

Look here

• pkg_managers.rs:98: public detect_npm_pkg_manager delegates to _with
• pkg_managers.rs:541: live_pnp_marker_in, where the linker is injected
• pkg_managers.rs:632: YarnPnpLoader::detect_with
• pkg_managers.rs:685: the hermetic test helper (reads only <project>/.yarnrc.yml)
• pkg_managers.rs:711: new tests covering public vs hermetic behaviour and an rc file above the project

Verified

• Read the full diff (2 files, +168/−60). No debug code or scope creep, and CHANGELOG.md is untouched.
• cargo test -p socket-patch-core --lib crawlers::pkg_managers passes: 51/51 clean, 51/51 with HOME containing .yarnrc.yml → nodeLinker: node-modules, and 51/51 with YARN_NODE_LINKER=node-modules. crawlers::pnpm_layout passes 4/4 under the hostile HOME.
• CI on 2abfc1e: ci-ok and clippy green (burn-down reports 50/50 done, 0 failed). Bugbot reviewed 2abfc1e and found nothing. No open review threads.

Changes I made. None.

Open questions (not blocking): should the follow-up for #1919 replace the *_hermetic twins with a single test-time override in YarnEnv? The PR description already proposes that, and npm_crawler and python_crawler are left for it.

Auto-merge is armed, so approving sends this straight to the merge queue.

Generated by Claude Code