GeezerVison

bugbot run

Generated by Claude Code

PR Summary

Low Risk
Production behavior is unchanged; only test helpers and internal _with methods were added, with no assertion changes.

Overview
Python crawler tests were failing when the developer had an activated venv or conda env because get_site_packages_paths and crawl_all always read VIRTUAL_ENV / CONDA_PREFIX from the real process environment.

This PR introduces injectable _with variants (get_site_packages_paths_with, crawl_all_with) that take an env lookup closure (matching local_site_packages_with). The public APIs still use std::env::var unchanged. Affected unit tests call the _with APIs with a no_env stub so fixtures aren’t overridden by the host. The Poetry virtualenv discovery test’s env guard also clears CONDA_PREFIX.

^{Reviewed by Cursor Bugbot for commit 144d4ab. Configure here.}

Ready for review at 144d4ab.

• CI: all checks finished with no failures (ci-ok, clippy, coverage, e2e shards all green; the rest skipped by path filters). No main-wide failures.
• Bugbot: reviewed 144d4ab and found nothing. No open review threads.
• Worth a reviewer's look: the private get_site_packages_paths_with / crawl_all_with seams (env lookup passed as a closure). The public entry points pass std::env::var exactly as before. Also the Poetry test's guard now clears CONDA_PREFIX.

Generated by Claude Code

Final review brief

What it does. Python crawler unit tests no longer depend on the host's activated venv or conda env. crawl_all and get_site_packages_paths now hand off to private *_with variants that take the env lookup as a closure. The public functions still pass the real process env, so production behaviour is unchanged. Five tests use an empty env, and the Poetry test's env guard also clears CONDA_PREFIX.

Risk: low. It touches one file. It is a pure refactor of two methods plus test-only changes. No assertion was changed and no test was removed.

Look here

• get_site_packages_paths_with: the public fn passes std::env::var and the body is unchanged
• crawl_all → crawl_all_with: same pattern
• no_env: the empty env used by the five tests
• Poetry test guard: CONDA_PREFIX cleared alongside VIRTUAL_ENV

Verified

• Read the full diff. The only process-env reads left on the local crawl path are in the public wrappers. The remaining std::env reads in the file are on global or Windows paths, which these tests don't hit.
• cargo test -p socket-patch-core --lib crawlers::python_crawler with VIRTUAL_ENV and CONDA_PREFIX set to a real venv: 102 passed on this head. On origin/main with VIRTUAL_ENV set: 5 failed, the same five listed in the description. So the tests fail without the change.
• CHANGELOG.md is untouched. CI: ci-ok and clippy are green on 144d4ab and no checks failed. Bugbot reviewed 144d4ab and found nothing. No open review threads.

Changes I made: none.
Open questions: none.

Auto-merge is armed, so approving sends it straight to the merge queue.

Generated by Claude Code