GeezerVison

LLM Description written by Claude Code:claude-opus-5-5

Fixes #326

Summary

scan --mode hosted and vendor no longer rewire an npm lock entry that npm installs from a git, remote-tarball (URL) or file: spec, and vex no longer attests one. Before this change both modes rewrote that entry's resolved/integrity and reported the package patched, and vex attested not_affected. Meanwhile npm ci fetched the git checkout or URL again and installed the original bytes.

Changes:

• vendor/npm_origin.rs (new): npm_non_registry_entries(lock) returns the packages keys npm installs from a non-registry source, each with a reason. An entry counts as non-registry in two cases:

  • An inbound dependency spec that resolves to it is not a registry spec. npm_spec_is_registry mirrors npm-package-arg: versions, ranges, dist-tags and npm: aliases count as registry; git, GitHub shorthand, URLs, paths and tarball names don't. The edges come from every entry's dependencies/optionalDependencies/devDependencies/peerDependencies, including the root and workspace members, resolved in node's lookup order.
  • Its own resolved is git+…/github:…/… or a file: outside .socket/vendor/.

  The spec check is what catches a URL spec whose resolved looks exactly like a registry tarball. It also catches an entry that has already been rewired: our own wiring only rewrites resolved, never the dependent's spec.

• Hosted (patch/redirect/mod.rs): such an entry is skipped with redirect_npm_non_registry_entry_skipped, a stays-UNPATCHED warning that names the entry and the spec. It still counts as a match, so redirect_npm_entry_not_found stays quiet.

• Vendored (vendor/npm_lock.rs): such an entry is skipped with vendor_non_registry_entry_skipped. When no rewritable copy is left, the vendor refuses with vendor_lock_entry_not_rewritable (the existing bundled/link refusal, with its wording widened) and writes nothing.

• v2 legacy mirror (both modes): in a lockfileVersion 2 lock, each legacy dependencies node maps to the packages key it mirrors (legacy_packages_key). A node whose twin is non-registry is left alone, even when it stores the plain version.

• VEX (vex/discover/npm.rs): each lock drops every ref whose name@version has a non-registry copy in that lock, diagnosed as patched_ref_unattributable. That copy also counts as resolved elsewhere, so it contests the same version in the sibling npm lock and in other lock types. This covers locks that were rewired before this fix, and a registry copy that is wired while a git copy of the same version stays unpatched next to it.

• Docs: a CHANGELOG Fixed entry, and the CLI_CONTRACT npm row.

Root cause

The npm lock rewriters pick entries by name and version only: rewrite_one_npm_lock and rewrite_npm_v2_deps for hosted, scan_lock_matches and rewrite_legacy_tree for vendored. Only link/inBundle entries are excluded. npm installs a git, URL or file: dependency from the dependent's spec and ignores the lock's resolved, so the rewrite had no effect at install time. VEX discovery trusted the rewired resolved in the same way.

Not affected: lockfileVersion 1. There, a git/URL/file: entry's version is the spec itself, so it never matches a patch's name@version.

Test evidence

Red was shown by stashing the three core source files and re-running the new tests against main's implementation. For the two v2-mirror tests, it was shown by disabling the new guard.

• cargo test -p socket-patch-core --all-features --lib -- npm vex::discover redirect: 1494 passed and 1 failed. The failure is vlt_heal::tests::an_unremovable_hidden_lock_keeps_every_store_entry, which fails on the unchanged branch too (the sandbox runs as root).
• SOCKET_PATCH_NPM_E2E_REQUIRED=1 cargo test -p socket-patch-cli --all-features --test e2e_vendor_npm_build --test e2e_redirect_npm_build -- --include-ignored (real npm 10.9.7, Node 22): 14 + 15 passed. The new e2e also passes against npm 12.1.0.
  • npm 12 refuses URL specs by default (EALLOWREMOTE). That made the new e2e fail its fixture install in CI's install-proof (12.x) legs, so it now passes --allow-remote=all on npm ≥ 12.
• cargo clippy --workspace --all-features -- -D warnings: clean.
• cargo fmt --all -- --check: the new code is rustfmt-clean. The remaining diffs are already on main, in files and hunks this PR doesn't touch.
• cargo test --workspace --all-features --no-fail-fast (on d53ef13): 10,407 passed and 22 failed. The 22 are the same sandbox-only set reported on Fix #258: state the real Maven Trusted Checksums floor #322, Fix Poetry venv discovery to match Poetry (#327, #329) #330 and Fix npm VEX attesting packages with an unpatched bundled copy (#325) #337: write-failure and permission tests that fail because the sandbox runs as root, plus the peak-RSS stage_local_artifact_caps_oversized_artifact_before_buffering. None of them are in npm or VEX code.
• CI on c46271c is green. Three jobs on earlier commits hit registry timeouts and passed on a re-run or on the next push: Composer/Windows (Packagist), macOS vlt 1.2.0 install-proof (npm registry) and macOS Poetry 1.8.5 (PyPI).
• CodeQL flagged two new test assertions for "cleartext logging" because they printed the patch URL with its uuid. Fixed in f07b94a, and the new diagnostic no longer prints the uuid either.
• The npm, PyPI and gem wrappers only dispatch, so they need no change.
• There's no real-npm hosted e2e for this. The hosted capstone fixture hard-codes a registry install, so the hosted path is covered by the rewriter unit tests above. The in-run scan --vex goes through the same discovery gate.

Notes

• This touches vex/discover/npm.rs next to Fix npm VEX attesting packages with an unpatched bundled copy (#325) #337, which adds a same-shaped gate for bundled copies. The two edit different functions (extract_package_lock here, push_uncontested there), so whichever lands second should need at most a trivial merge.
• Known limit: when a root overrides entry forces a URL spec onto a registry-range edge, the lock alone doesn't show it. The resolved check still catches forced git and file: sources.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LycgFGuki2BqZ25VNhwxJ5

Generated by Claude Code