GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add explicit node types for TypeScript 6 compat by Raynos · Pull Request #51 · SocketDev/socket-patch

Conversation

@Raynos

@Raynos Jake Verbaten (Raynos) commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds "types": ["node"] to npm/socket-patch/tsconfig.json
  • TypeScript 6.0 changed default types behavior so node types are no longer auto-included
  • This fixes project reference builds in depscan after upgrading to TS 6

Based on v2.0.0 so depscan can consume it without lockfile changes.

Context

SocketDev/depscan#18896 is upgrading depscan to TypeScript 6.0.2.

Test plan

  • Verify tsc -b npm/socket-patch still builds successfully

Made with Cursor

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Raynos
Add explicit node types for TypeScript 6 compat
db5819b 
TypeScript 6.0 changed the default types behavior
so node types are no longer auto-included. This
fixes builds in projects that use TS 6.

Made-with: Cursor
Copilot AI review requested due to automatic review settings April 2, 2026 13:54
Copilot started reviewing on behalf of Jake Verbaten (Raynos) April 2, 2026 13:55
View session
Copilot AI reviewed Apr 2, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the @socketsecurity/socket-patch TypeScript project config to explicitly include Node.js ambient type definitions, aligning the package with TypeScript 6’s changed default behavior for automatic @types/* inclusion and keeping project-reference builds working for depscan.

Changes:

  • Add "types": ["node"] to npm/socket-patch/tsconfig.json to ensure Node globals/types are available during compilation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Wenxin-Jiang
Wenxin Jiang (Wenxin-Jiang) approved these changes Apr 2, 2026
View reviewed changes
@Raynos
Jake Verbaten (Raynos) merged commit 5960fb5 into main Apr 3, 2026
23 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@Raynos
Jake Verbaten (Raynos) deleted the fix/ts6-types-node-v2 branch April 3, 2026 09:14
Jake Verbaten (Raynos) added a commit that referenced this pull request Apr 6, 2026
@Raynos
Add explicit node types for TypeScript 6 compat (#51)
374de97 
TypeScript 6.0 changed the default types behavior
so node types are no longer auto-included. This
fixes builds in projects that use TS 6.

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@Wenxin-Jiang Wenxin Jiang (Wenxin-Jiang) Wenxin-Jiang approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Raynos @Wenxin-Jiang
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.