GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix report links in Console and JSON by jdalton · Pull Request #396 · SocketDev/socket-python-cli

Conversation

@jdalton

@jdalton John-David Dalton (jdalton) commented Oct 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Console output now links to the correct comparison or full-scan report, and standard JSON exposes both scan and comparison references.

A typed report-reference value keeps diff and full-scan URLs distinct. Clean summaries still start with No issues found; JSON adds full_scan_id and diff_url alongside the existing fields.

Validation: 11 focused tests and scoped Ruff/format checks pass. Existing formatting differences in output.py remain untouched.

N/A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jdalton
John-David Dalton (jdalton) requested a review from a team as a code owner October 12, 2026 22:32
@jdalton John-David Dalton (jdalton) mentioned this pull request Oct 13, 2026
Preserve comparison and scan identities #398
Open
@jdalton
John-David Dalton (jdalton) force-pushed the codex/surf199-python-report-refs branch from f57b781 to 6b7da03 Compare October 13, 2026 16:11
@jdalton
John-David Dalton (jdalton) temporarily deployed to socket-firewall October 13, 2026 16:12 — with GitHub Actions Inactive
@jdalton
John-David Dalton (jdalton) temporarily deployed to socket-firewall October 13, 2026 16:12 — with GitHub Actions Inactive
@jdalton John-David Dalton (jdalton) mentioned this pull request Oct 13, 2026
Use server-provided scan report links #399
Open
@jdalton
John-David Dalton (jdalton) force-pushed the codex/surf199-python-report-refs branch from 6b7da03 to 6b113c0 Compare October 13, 2026 16:49
@jdalton
John-David Dalton (jdalton) temporarily deployed to socket-firewall October 13, 2026 16:49 — with GitHub Actions Inactive
@jdalton
John-David Dalton (jdalton) added this pull request to stack #401 October 13, 2026 16:58
This was referenced Oct 13, 2026
Expose scan references in JSON reports #402
Open
Include package changes in JSON reports #403
Open
@jdalton
Fix report links in Console and JSON
524856b
Assisted-by: Codex:gpt-6-luna
@jdalton
John-David Dalton (jdalton) force-pushed the codex/surf199-python-report-refs branch from 6b113c0 to 524856b Compare October 28, 2026 20:53
@jdalton
fix: bump version for report link fix
fa2a390
@jdalton
John-David Dalton (jdalton) temporarily deployed to socket-firewall October 28, 2026 21:02 — with GitHub Actions Inactive
@lelia

lelia commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Before review: #398–#406 need rebasing onto this branch. #396 was rebased on Oct 28, but the PRs above it still carry the earlier copy of its commit (6b113c0 rather than 524856b). As a result, #398's diff repeats this PR's changes (16 files, +1,538), and #396 and #398 show conflicts with main. The conflicts are only in pyproject.toml, socketsecurity/__init__.py and uv.lock; the code merges cleanly.

Please fetch before rebasing: I pushed 697e2d3 to #399's branch. It puts back test_explicit_discovery_results_prevent_a_second_walk, which only failed because its stub had no html_report_url.

On the version: this branch sets 2.11.5, and main is already at 2.11.8. The stack adds new fields to the standard JSON output (#402, #403, #406), so it should ship as one minor release. Could you keep a single bump here at 2.12.0 and leave the version alone in the other PRs?

Also, #407 is built on #406's branch but isn't part of this stack. If it's meant to ship with the stack, please add it so it appears on the stack page.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lelia

lelia commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Two follow-ups to my comment above:

  • Correction: main is now at 2.11.11, not 2.11.8. The conflicts are still only in the version files.
  • None of the PRs in the stack touch CHANGELOG.md, and the Public Changelog section here is still the template's N/A. This PR changes console output: diff runs now link to the comparison instead of the full-scan report, and clean runs print the link after No issues found. The rest of the stack adds JSON fields. Could you add a 2.12.0 section to CHANGELOG.md alongside the version bump?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch was previously deployed

1 inactive deployment
socket-firewall — fa2a390e Deployed Oct 28, 2026 by jdalton via python-sfw-smoke-enterprise #532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jdalton @lelia
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.