GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix exit code from returning 5 on diff reports with no error alerts a… by dacoburn · Pull Request #99 · SocketDev/socket-python-cli

Conversation

@dacoburn

@dacoburn Douglas (dacoburn) commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

…nd only warn

Root Cause

Logic was incorrectly added to have the CLI exit with error code 5 if there were only warn alerts in the diff report. This was not the intended behavior.

Fix

Removed this incorrect logic

Public Changelog

  • Updated the CLI to return 0 for the exit code if the only alerts in the diff report are warn alerts instead of incorrectly returning 5

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dacoburn
Fix exit code from returning 5 on diff reports with no error alerts a…
3c9e339 
…nd only warn
@dacoburn
Douglas (dacoburn) requested a review from a team as a code owner June 30, 2025 18:17
@dacoburn
Douglas (dacoburn) requested review from Anders Møller (amoeller) and Jeppe Fredsgaard Blaabjerg (jfblaa) and removed request for a team June 30, 2025 18:17
@dacoburn Douglas (dacoburn) added the Product Changelog New features for the public changelog label Jun 30, 2025
@github-actions

github-actions Bot commented Jun 30, 2025

Copy link
Copy Markdown

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.1.19.dev1

Docker image: socketdev/cli:pr-99
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pvdz
Peter van der Zee (pvdz) approved these changes Jun 30, 2025
View reviewed changes
@dacoburn
Douglas (dacoburn) merged commit 1717d0a into main Jun 30, 2025
@dacoburn
Douglas (dacoburn) deleted the doug/fix-exit-code-on-warn branch June 30, 2025 18:27
This was referenced Aug 5, 2026
Fix intermittent connection resets on scan comparison by polling the diff-scans endpoints #284
Merged
Raise failure on SBOM fetch errors #288
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvdz Peter van der Zee (pvdz) pvdz approved these changes
@amoeller Anders Møller (amoeller) Awaiting requested review from amoeller amoeller was automatically assigned from SocketDev/eng
@jfblaa Jeppe Fredsgaard Blaabjerg (jfblaa) Awaiting requested review from jfblaa jfblaa was automatically assigned from SocketDev/eng

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Product Changelog New features for the public changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dacoburn @pvdz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.