GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: alternative_password_generator respects requested length by dbdefault · Pull Request #15719 · TheAlgorithms/Python

Conversation

dbdefault commented Nov 12, 2026

Copy link

Copy Markdown

Fixes #15633

Describe your change

�lternative_password_generator now raises ValueError when the requested
length i is smaller than len(chars_incl), instead of silently returning
a longer password.
Added doctests covering valid and invalid inputs.

Checklist

I have read the contributing guidelines
I have run
uff check and
uff format on my changes
I have added doctests for any new or changed functions
My change is one algorithm file

Fixes #15633

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fix: alternative_password_generator respects requested length

9ae427a

Guard against i < len(chars_incl) so the returned password never exceeds
the requested length. Add doctests covering valid and invalid inputs.

Fixes TheAlgorithms#15633

algorithms-keeper Bot added awaiting reviews

This PR is ready to be reviewed

enhancement This PR modified some existing files labels

Nov 12, 2026

This was referenced Nov 12, 2026

fix: des_ecb accepts bytes input instead of str #15722

Closed

fix: base58.py implements real Base58 encoding/decoding #15724

Closed

fix: binomial_distribution overflow at 171 trials #15725

Closed

fix: continued_fraction float division producing invalid terms #15726

Closed

Fix #15576: Optimize has_loop to O(1) space #15727

Closed

This branch has not been deployed

No deployments

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting reviews

This PR is ready to be reviewed

enhancement

This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

other/password.py: alternative_password_generator ignores the requested length when the required characters exceed it

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.