GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: des_ecb accepts bytes input instead of str by dbdefault · Pull Request #15722 · TheAlgorithms/Python

Conversation

dbdefault commented Nov 12, 2026

Copy link

Copy Markdown

Fixes #15634

Describe your change

ciphers/des_ecb.py: Operations.string_to_bitset now accepts bytes instead of str, iterating over raw byte values rather than Unicode code points
bitset_to_string returns bytes instead of str, so non-Latin-1 bytes round-trip correctly
Des.encrypt/Des.decrypt encode/decode input/output as UTF-8, making any Unicode text round-trip correctly (matching crc32.py convention)
Add doctests covering ASCII and non-ASCII inputs

Checklist

I have read the contributing guidelines
I have run ruff check and ruff format on my changes
I have added doctests for any new or changed functions
My change is one algorithm file

Fixes #15634

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fix: des_ecb accepts bytes input instead of str

10adf48

string_to_bitset now accepts bytes and iterates over raw byte values
rather than Unicode code points. bitset_to_string returns bytes.
Des.encrypt/Des.decrypt encode/decode input/output as UTF-8, making
any Unicode text round-trip correctly (consistent with crc32.py).

Fixes TheAlgorithms#15634

algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label

Nov 12, 2026

algorithms-keeper Bot commented Nov 12, 2026

Copy link

Copy Markdown

Multiple Pull Request Detected

@dbdefault, we are extremely excited that you want to submit multiple algorithms in this repository but we have a limit on how many pull request a user can keep open at a time. This is to make sure all maintainers and users focus on a limited number of pull requests at a time to maintain the quality of the code.

This pull request is being closed as the user already has an open pull request. Please focus on your previous pull request before opening another one. Thank you for your cooperation.

User opened pull requests (including this one): #15722, #15721, #15720, #15719

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

algorithms-keeper Bot closed this

Nov 12, 2026

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting reviews

This PR is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ciphers/des_ecb.py: encrypt/decrypt silently corrupts any character above U+00FF (round-trip fails)

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.