GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix bug in filtering Kotlin getters/setters in plugin by volivan239 · Pull Request #1026 · UnitTestBot/UTBotJava

Conversation

@volivan239

@volivan239 volivan239 commented Sep 28, 2022

Copy link
Copy Markdown
Collaborator

Description

Filtering Kotlin getters/setters in plugin was added in #1003, however, there was a major bug in that fix (filter was checking condition that was always true).

Fixes #911

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual Scenario

Re-checked on scenario from #1003 -- now works correctly.

Checklist (remove irrelevant options):

This is the author self-check list

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@volivan239
Fix bug in filtering Kotlin getters/setters in plugin
667f05a
@volivan239
volivan239 requested a review from Vassiliy-Kudryashov September 28, 2022 13:44
@volivan239
volivan239 marked this pull request as ready for review September 28, 2022 14:14
Vassiliy-Kudryashov
Vassiliy-Kudryashov approved these changes Sep 28, 2022
View reviewed changes
@volivan239
volivan239 enabled auto-merge (squash) September 28, 2022 14:36
@volivan239
volivan239 merged commit 560ac03 into main Sep 28, 2022
@volivan239
volivan239 deleted the volivan239/fix_kotlin_getters_setters_appear_in_ui branch September 28, 2022 16:31
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@volivan239 @AbdullinAM
Fix bug in filtering Kotlin getters/setters in plugin (UnitTestBot#1026)
258d962
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@volivan239 @AbdullinAM
Fix bug in filtering Kotlin getters/setters in plugin (UnitTestBot#1026)
608d56c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vassiliy-Kudryashov Vassiliy-Kudryashov Vassiliy-Kudryashov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Autogenerated Kotlin getters/setters shouldn't be tested

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@volivan239 @Vassiliy-Kudryashov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.