GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Modificators processing in AssembleModelGenerator and UtBotFieldModificatorsSearcher corrected by EgorkaKulikov · Pull Request #1029 · UnitTestBot/UTBotJava

Conversation

@EgorkaKulikov

@EgorkaKulikov EgorkaKulikov commented Sep 28, 2022

Copy link
Copy Markdown
Collaborator

Description

Searcher of field modificators fixed for default package: in the previous implementation it considered all modificators appropriate if they are located in a default package.

Fixes # (1024)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Automated Testing

UtBotFieldModificatorsTest

Manual Scenario

Repeat the scenario described in the mentioned feature with fuzzer and concrete executor turned off.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EgorkaKulikov
EgorkaKulikov requested a review from volivan239 September 28, 2022 19:12
@EgorkaKulikov
EgorkaKulikov force-pushed the egor/fms_default_package branch from 02fdc9e to 122d408 Compare September 29, 2022 08:08
@EgorkaKulikov
EgorkaKulikov marked this pull request as draft September 29, 2022 15:24
@EgorkaKulikov
EgorkaKulikov marked this pull request as ready for review September 29, 2022 22:10
@EgorkaKulikov
EgorkaKulikov marked this pull request as draft September 30, 2022 08:21
@EgorkaKulikov
EgorkaKulikov force-pushed the egor/fms_default_package branch from c4444b7 to 6049c5f Compare September 30, 2022 15:40
@EgorkaKulikov
EgorkaKulikov marked this pull request as ready for review September 30, 2022 16:05
@EgorkaKulikov EgorkaKulikov changed the title Searcher of field modificators fixed for default package. Modificators processing in AssembleModelGenerator and UtBotFieldModificatorsSearcher corrected Sep 30, 2022
@EgorkaKulikov
EgorkaKulikov force-pushed the egor/fms_default_package branch from 6049c5f to 32a3394 Compare September 30, 2022 16:10
@EgorkaKulikov
Improve modificators analysis in UtBotFieldModificatorsSearcher and A…
b12f7c3 
…ssembleModelGenerator
@EgorkaKulikov
EgorkaKulikov force-pushed the egor/fms_default_package branch from c88756c to b12f7c3 Compare September 30, 2022 16:11
volivan239
volivan239 requested changes Oct 2, 2022
View reviewed changes

@volivan239 volivan239 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, but please check the comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread utbot-framework/src/main/kotlin/org/utbot/framework/assemble/AssembleModelGenerator.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread ...amework/src/main/kotlin/org/utbot/framework/modifications/UtBotFieldsModificatorsSearcher.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread ...amework/src/main/kotlin/org/utbot/framework/modifications/UtBotFieldsModificatorsSearcher.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.
EgorkaKulikov added 5 commits October 3, 2022 11:34
@EgorkaKulikov
Apply review comments
afc00d9
@EgorkaKulikov
Merge branch 'main' into egor/fms_default_package
a0300ce
@EgorkaKulikov
Fixed test
213e6df
@EgorkaKulikov
One more correction for package names
332712c
@EgorkaKulikov
Merge branch 'main' into egor/fms_default_package
7f42484
volivan239
volivan239 approved these changes Oct 3, 2022
View reviewed changes
@EgorkaKulikov
EgorkaKulikov merged commit 19b0f78 into main Oct 3, 2022
@EgorkaKulikov
EgorkaKulikov deleted the egor/fms_default_package branch October 3, 2022 13:30
@volivan239 volivan239 mentioned this pull request Oct 4, 2022
Incorrect reflection call leads to compilation errors #1024
Closed
@alisevych alisevych added this to the 2022.10.1 Release milestone Oct 7, 2022
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@EgorkaKulikov @AbdullinAM
Modificators processing in AssembleModelGenerator and UtBotFieldModif…
9b5d7bb 
…icatorsSearcher corrected (UnitTestBot#1029)

* Improve modificators analysis in UtBotFieldModificatorsSearcher and AssembleModelGenerator

* Apply review comments

* Fixed test

* One more correction for package names
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@EgorkaKulikov @AbdullinAM
Modificators processing in AssembleModelGenerator and UtBotFieldModif…
ba08cb7 
…icatorsSearcher corrected (UnitTestBot#1029)

* Improve modificators analysis in UtBotFieldModificatorsSearcher and AssembleModelGenerator

* Apply review comments

* Fixed test

* One more correction for package names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@volivan239 volivan239 volivan239 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2022.10.1 Release

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@EgorkaKulikov @volivan239 @alisevych
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.