GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Try to fix memory leak in CgComponents by EgorkaKulikov · Pull Request #1057 · UnitTestBot/UTBotJava

Conversation

@EgorkaKulikov

@EgorkaKulikov EgorkaKulikov commented Oct 3, 2022

Copy link
Copy Markdown
Collaborator

Description

The following chain of dependencies leads us to the memory leaks.

  • we have an OBJECT `CgComponents'
  • it has a map called fieldStateManagers that is never cleaned
  • each key of type CgContext contains allExecutions field, that requires much memory

Actually, other maps have the same key, so they need to be replaced with better design solutions too.

Fixes # (1054)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual Scenario

Performance testing on the similar examples that were used to reproduce the issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EgorkaKulikov
EgorkaKulikov requested a review from Damtev October 3, 2022 14:01
EgorkaKulikov added 4 commits October 4, 2022 11:23
@EgorkaKulikov
Try to fix memory leak in CgFieldStateManager
a840197
@EgorkaKulikov
Removed unused testClassConstructors
eac6370
@EgorkaKulikov
Make CgContext much more thin
9442d38
@EgorkaKulikov
Clear content related maps before the processing of new test class
7b2c466
@EgorkaKulikov
EgorkaKulikov force-pushed the egor/leak_fieldstatemanager branch from a7f0c86 to 7b2c466 Compare October 4, 2022 08:24
Damtev
Damtev approved these changes Oct 4, 2022
View reviewed changes

@Damtev Damtev left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EgorkaKulikov
EgorkaKulikov merged commit c9c2a0b into main Oct 4, 2022
@EgorkaKulikov
EgorkaKulikov deleted the egor/leak_fieldstatemanager branch October 4, 2022 09:15
@alisevych alisevych added this to the 2022.10.1 Release milestone Oct 7, 2022
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@EgorkaKulikov @AbdullinAM
Try to fix memory leak in CgComponents (UnitTestBot#1057)
bbb082c 
* Try to fix memory leak in CgFieldStateManager

* Removed unused testClassConstructors

* Make CgContext much more thin

* Clear content related maps before the processing of new test class
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@EgorkaKulikov @AbdullinAM
Try to fix memory leak in CgComponents (UnitTestBot#1057)
b6d8a65 
* Try to fix memory leak in CgFieldStateManager

* Removed unused testClassConstructors

* Make CgContext much more thin

* Clear content related maps before the processing of new test class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Damtev Damtev Damtev approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2022.10.1 Release

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@EgorkaKulikov @Damtev @alisevych
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.