GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Lessen thisInstance creation in parameterized test generation by sofurihafe · Pull Request #1065 · UnitTestBot/UTBotJava

Conversation

@sofurihafe

@sofurihafe sofurihafe commented Oct 4, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Description

This PR lessens thisInstance creations in parameterized test generation moving them from data providers to generic test frame.

Type of Change

  • New feature/optimization (non-breaking change which adds functionality)

How Has This Been Tested?

Automated Testing

utbot-samples

Manual Scenario

Enable parameterized test generation. Run, for example, StaticSubstitutionExamplesTest and verify that generic test frame has thisInstance initialization, while data providers don't have it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sofurihafe
Lessen thisInstance creation in parameterized test generation
94e8f9e
@sofurihafe
sofurihafe requested a review from EgorkaKulikov October 4, 2022 07:43
@sofurihafe
sofurihafe marked this pull request as ready for review October 4, 2022 07:44
EgorkaKulikov
EgorkaKulikov approved these changes Oct 4, 2022
View reviewed changes
EgorkaKulikov added 4 commits October 4, 2022 12:46
@EgorkaKulikov
Merge branch 'main' into andrey-t/parameterized-tests-this-instance
88eabf5
@EgorkaKulikov
Merge branch 'main' into andrey-t/parameterized-tests-this-instance
0684d2a
@EgorkaKulikov
Avoid incorrect configuration
339bd64
@EgorkaKulikov
Merge branch 'main' into andrey-t/parameterized-tests-this-instance
30c35ab
@EgorkaKulikov
EgorkaKulikov merged commit 56bf6ab into main Oct 7, 2022
@EgorkaKulikov
EgorkaKulikov deleted the andrey-t/parameterized-tests-this-instance branch October 7, 2022 13:11
@alisevych alisevych added this to the 2022.10.1 Release milestone Oct 10, 2022
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@sofurihafe @EgorkaKulikov @AbdullinAM
Lessen thisInstance creation in parameterized test generation (UnitTe…
8ca3c88
…stBot#1065)

* Lessen thisInstance creation in parameterized test generation

* Avoid incorrect configuration

Co-authored-by: Egor Kulikov <[email protected]>
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@sofurihafe @EgorkaKulikov @AbdullinAM
Lessen thisInstance creation in parameterized test generation (UnitTe…
ad150ba
…stBot#1065)

* Lessen thisInstance creation in parameterized test generation

* Avoid incorrect configuration

Co-authored-by: Egor Kulikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EgorkaKulikov EgorkaKulikov EgorkaKulikov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2022.10.1 Release

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sofurihafe @EgorkaKulikov @alisevych
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.