GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixed unavailable mock classes by Damtev · Pull Request #1066 · UnitTestBot/UTBotJava

Conversation

@Damtev

@Damtev Damtev commented Oct 4, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Description

After introducing nullability and single type parameter for Kotlin code generation, static mocks became broken - they were no longer considered as BuiltinClassId, which means they were tried to load with default class loader which is impossible due to classes from mock frameworks could not be load with it.

This request makes mock classes builtin again - it fixes the problem but is incorrect for Kotlin code generation. The proper support of it should be designed and implemented together with generics in code generation (as planned in #88).

Fixes #981.

Type of Change

Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Manual Scenario

Generating tests as mentioned in the issue.

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • All tests pass locally with my changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Damtev
Damtev requested review from EgorkaKulikov and sergeypospelov October 4, 2022 07:57
@Damtev
Fixed error with unavailable mock classes from mock framework
a53d179
@Damtev
Damtev force-pushed the damtev/static_mocks_fix branch 3 times, most recently from 29e726f to 11820f0 Compare October 4, 2022 11:02
EgorkaKulikov
EgorkaKulikov approved these changes Oct 4, 2022
View reviewed changes
@Damtev
Disabled Kotlin codegen tests with static mocks
4c29331
@Damtev
Damtev force-pushed the damtev/static_mocks_fix branch from 11820f0 to 4c29331 Compare October 4, 2022 11:27
sergeypospelov
sergeypospelov approved these changes Oct 5, 2022
View reviewed changes
@Damtev
Damtev merged commit 1260c8f into main Oct 5, 2022
@Damtev
Damtev deleted the damtev/static_mocks_fix branch October 5, 2022 06:21
denis-fokin pushed a commit that referenced this pull request Oct 5, 2022
@Damtev @denis-fokin
Fixed unavailable mock classes (#1066)
3f19f45
(cherry picked from commit 1260c8f)
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@Damtev @AbdullinAM
Fixed unavailable mock classes (UnitTestBot#1066)
dba55a5
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@Damtev @AbdullinAM
Fixed unavailable mock classes (UnitTestBot#1066)
8016349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EgorkaKulikov EgorkaKulikov EgorkaKulikov approved these changes
@sergeypospelov sergeypospelov sergeypospelov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Couldn't generate some tests: 2 occurrences of org.mockito.MockedStatic

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Damtev @EgorkaKulikov @sergeypospelov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.