GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — We create temporary files a lot, we have to clean it either by Vassiliy-Kudryashov · Pull Request #1089 · UnitTestBot/UTBotJava

Conversation

@Vassiliy-Kudryashov

@Vassiliy-Kudryashov Vassiliy-Kudryashov commented Oct 4, 2022

Copy link
Copy Markdown
Member

Description

New cleaning stage was added for files outside "UTBot" directory

Type of Change

  • Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Manual Scenario

Check tempDir, it may contain a lot of small files named like:

  • Graph-vis***
  • {some digits}-0
  • byteBuddyAgent***.jar
  • mockitoboot***.jar
    We never clean it but we have to.

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • No new warnings

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Vassiliy-Kudryashov
We create temporary files a lot, we have to clean it either
bf1e1d9
@Vassiliy-Kudryashov
Vassiliy-Kudryashov requested a review from Markoutte October 4, 2022 17:51
@Vassiliy-Kudryashov
We create temporary files a lot, we have to clean it either
bcc37a2
@Vassiliy-Kudryashov
Vassiliy-Kudryashov enabled auto-merge (squash) October 4, 2022 17:52
@Vassiliy-Kudryashov
Vassiliy-Kudryashov requested a review from Damtev October 5, 2022 08:39
@Vassiliy-Kudryashov

Vassiliy-Kudryashov commented Oct 5, 2022

Copy link
Copy Markdown
Member Author

Windows never automatically cleans the %TEMP% directory by default. In Windows 10 you have to enable this feature in Settings, and with earlier versions you must delete the files yourself or use programs like Disk Cleanup or cCleaner.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Damtev
Damtev requested changes Oct 5, 2022
View reviewed changes
Comment thread utbot-core/src/main/kotlin/org/utbot/common/FileUtil.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread utbot-core/src/main/kotlin/org/utbot/common/FileUtil.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Vassiliy-Kudryashov and others added 2 commits October 6, 2022 13:36
@Vassiliy-Kudryashov
We create temporary files a lot, we have to clean it either
11ee557 
The fix: our own temp files are moved to UTBot subfolder where existing auto-cleaning does the job
@Vassiliy-Kudryashov
Merge branch 'main' into Vassiliy-Kudryashov/tmpDir_cleaning
e822dea
Damtev
Damtev approved these changes Oct 7, 2022
View reviewed changes

@Damtev Damtev left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Vassiliy-Kudryashov
Vassiliy-Kudryashov merged commit 31a2f7d into main Oct 7, 2022
@Vassiliy-Kudryashov
Vassiliy-Kudryashov deleted the Vassiliy-Kudryashov/tmpDir_cleaning branch October 7, 2022 04:53
@alisevych alisevych added this to the 2022.10.1 Release milestone Oct 7, 2022
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@Vassiliy-Kudryashov @AbdullinAM
We create temporary files a lot, we have to clean it either (UnitTest…
58b4755 
…Bot#1089)
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@Vassiliy-Kudryashov @AbdullinAM
We create temporary files a lot, we have to clean it either (UnitTest…
a215477 
…Bot#1089)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Damtev Damtev Damtev approved these changes
@Markoutte Markoutte Awaiting requested review from Markoutte

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2022.10.1 Release

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Vassiliy-Kudryashov @Damtev @alisevych
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.