GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve verification that static mocking is configured by EgorkaKulikov · Pull Request #1091 · UnitTestBot/UTBotJava

Conversation

@EgorkaKulikov

@EgorkaKulikov EgorkaKulikov commented Oct 5, 2022

Copy link
Copy Markdown
Collaborator

Description

Current implementation of searching that static mocking is configured has a problem that we firstly obtain all file names from the content entry and only after that verify that a required name is present. It will lead us to problems if there are millions of files in the content entry.
Implementation was improved in accordance with lazy practices.

Type of Change

  • Refactoring (typos and non-functional changes)

How Has This Been Tested?

Manual Scenario

Verify that we do not create tests with static mocking if there is no special file in any of test source root resource folders.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EgorkaKulikov
EgorkaKulikov force-pushed the egor/static_mocks_file_search branch from 6444031 to 825b853 Compare October 5, 2022 08:23
EgorkaKulikov added 2 commits October 5, 2022 12:37
@EgorkaKulikov
Improve verification that static mocking is configured
ff827eb
@EgorkaKulikov
Wrap file reading with try/catch
e358e0a
@EgorkaKulikov
EgorkaKulikov force-pushed the egor/static_mocks_file_search branch from 9090cd7 to e358e0a Compare October 5, 2022 09:37
@EgorkaKulikov
EgorkaKulikov requested a review from mmvpm October 5, 2022 09:57
mmvpm
mmvpm approved these changes Oct 5, 2022
View reviewed changes
@EgorkaKulikov
EgorkaKulikov merged commit c34324a into main Oct 5, 2022
@EgorkaKulikov
EgorkaKulikov deleted the egor/static_mocks_file_search branch October 5, 2022 11:49
@alisevych alisevych added this to the 2022.10.1 Release milestone Oct 7, 2022
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@EgorkaKulikov @AbdullinAM
Improve verification that static mocking is configured (UnitTestBot#1091
441700b 
)

* Improve verification that static mocking is configured

* Wrap file reading with try/catch
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@EgorkaKulikov @AbdullinAM
Improve verification that static mocking is configured (UnitTestBot#1091
cd3dcd1 
)

* Improve verification that static mocking is configured

* Wrap file reading with try/catch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmvpm mmvpm mmvpm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2022.10.1 Release

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@EgorkaKulikov @mmvpm @alisevych
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.