GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Filter generated sources in Android Studio projects by EgorkaKulikov · Pull Request #1123 · UnitTestBot/UTBotJava

Conversation

@EgorkaKulikov

@EgorkaKulikov EgorkaKulikov commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

Description

We should not suggest generated sources folders to user to generate tests in. We filter them.
In standard projects we use flag isForGeneratedSources. Android Studio does not support this project model, so we can only apply filtering on keywords in the path.

Fixes # (692)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual Scenario

Check that there are no generated sources folders in the combobox for test source roots on UI before the first test generated and after it also (when generated sources folder have already aprreared).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
EgorkaKulikov added 2 commits October 10, 2022 13:29
@EgorkaKulikov
Filter generated sources in Android Studio projects
9b5ba58
@EgorkaKulikov
Merge branch 'main' into egor/android_studio_source_roots
cbdf699
volivan239
volivan239 approved these changes Oct 10, 2022
View reviewed changes
@EgorkaKulikov
EgorkaKulikov merged commit 134f6c7 into main Oct 10, 2022
@EgorkaKulikov
EgorkaKulikov deleted the egor/android_studio_source_roots branch October 10, 2022 12:29
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@EgorkaKulikov @AbdullinAM
Filter generated sources in Android Studio projects UnitTestBot#692 (U…
5057657 
…nitTestBot#1123)
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@EgorkaKulikov @AbdullinAM
Filter generated sources in Android Studio projects UnitTestBot#692 (U…
c7618bb 
…nitTestBot#1123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@volivan239 volivan239 volivan239 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@EgorkaKulikov @volivan239
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.