GeezerVison is showing github.com — Fix static mocking by SBOne-Kenobi · Pull Request #1142 · UnitTestBot/UTBotJava
Conversation
Description
Mocking in concrete executor respected only method signature without any information about declaring class. Therefore, when we wanted to mock two methods with the same signatures but in different classes, we ignored mocking one of them.
Now, new signature of method includes fully qualified name of declaring class.
Fixes #1128
Type of Change
Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Manual Scenario
Described in issue #1128
Checklist:
- The change followed the style guidelines of the UTBot project
- Self-review of the code is passed
- The change contains enough commentaries, particularly in hard-to-understand areas
- New documentation is provided or existed one is altered
- No new warnings
- New tests have been added
- All tests pass locally with my changes
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
mmvpm
mmvpm approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Bad static method mocking
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.