GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add disjunction with null condition to isMock constraint by CaelmBleidd · Pull Request #1521 · UnitTestBot/UTBotJava

Conversation

@CaelmBleidd

@CaelmBleidd CaelmBleidd commented Dec 15, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Description

Added a disjunction with nullability constraint to avoid an assignment to a null object contradicting conditions about whether it is mock or not.

Fixes #1520

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Regression and integration tests

There is no difference between automatic tests and international tests for the engine.

Automated Testing

org.utbot.examples.mock.CommonMocksExample#mocksForNullOfDifferentTypes

Manual Scenario

Did not check it manually.

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@CaelmBleidd
CaelmBleidd requested a review from sergeypospelov December 15, 2022 05:40
@CaelmBleidd
Add disjunction with null condition to isMock constraint
fda8e9f
@CaelmBleidd
CaelmBleidd force-pushed the caelmbleidd/null_values_as_mock_fix branch from 55e5eec to fda8e9f Compare December 15, 2022 06:03
sergeypospelov
sergeypospelov approved these changes Dec 15, 2022
View reviewed changes

@sergeypospelov sergeypospelov left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@CaelmBleidd
CaelmBleidd merged commit e28e14c into main Dec 15, 2022
@CaelmBleidd
CaelmBleidd deleted the caelmbleidd/null_values_as_mock_fix branch December 15, 2022 08:58
tamarinvs19 pushed a commit that referenced this pull request Dec 21, 2022
@CaelmBleidd @tamarinvs19
Add disjunction with null condition to isMock constraint (#1521)
6cd68c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergeypospelov sergeypospelov sergeypospelov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mock label is assigned to null values

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@CaelmBleidd @sergeypospelov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.