GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Removed enum constants from meaningful static fields by Damtev · Pull Request #1561 · UnitTestBot/UTBotJava

Conversation

@Damtev

@Damtev Damtev commented Dec 21, 2022

Copy link
Copy Markdown
Member

Description

Removed enum constants from meaningful static fields - previously enum constants were explicitly set in the generated tests.

Fixes #618.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Regression and integration tests

Not applicable

Automated Testing

Existing enum tests from the org.utbot.examples.enums package.

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • All tests pass locally with my changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Damtev
Removed enum constants from meaningful static fields
be970cc
@Damtev
Damtev requested a review from CaelmBleidd December 21, 2022 03:23
CaelmBleidd
CaelmBleidd approved these changes Dec 21, 2022
View reviewed changes
@Damtev
Damtev merged commit 295ede5 into main Dec 21, 2022
@Damtev
Damtev deleted the damtev/removed_meaningful_enum_constants branch December 21, 2022 04:25
denis-fokin pushed a commit that referenced this pull request Dec 21, 2022
@Damtev @denis-fokin
Removed enum constants from meaningful static fields (#1561)
9c3f875 
(cherry picked from commit 295ede5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaelmBleidd CaelmBleidd CaelmBleidd approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Useless assignment of enum values to corresponding static fields in generated tests

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Damtev @CaelmBleidd
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.