GeezerVison is showing github.com — Try another approach to mark hanging generated tests #371 by Vassiliy-Kudryashov · Pull Request #554 · UnitTestBot/UTBotJava
Conversation
Description
Note, this issue affects JUnit 5 only!
New methods and entities were added to codegen to provide required assertion wrapper. Now tests with timeout are being abrupt just after exceeding time limit.
Fixes #371
Type of Change
Please delete options that are not relevant.
- New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Manual Scenario
Set handing test timeout to 100ms and generate tests for the example:
package issue371;
import java.io.File;
public class PomXmlFinder {
public static void main(String[] args) {
scan(new File("C:\\"));
}
private static int counter = 0;
private static void scan(File file) {
if (counter > 10) return;
if (file.isFile() && file.getName().equals("pom.xml")) {
counter++;
if (counter > 10) return;
System.out.println(file.getAbsolutePath());
}
File[] files = file.listFiles();
if (files != null) {
for (File child : files) {
scan(child);
}
}
}
}
Generated test methods should be not only annotated with @Timeout tag but also have wrappers like assertTimeoutPreemptively(Duration.ofMillis(100L), () -> PomXmlFinder.main(stringArray)); inside
Checklist (remove irrelevant options):
- The change followed the style guidelines of the UTBot project
- Self-review of the code is passed
- No new warnings
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
Damtev
Damtev approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.