GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Read npm licenses from the selected release by codewithfourtix · Pull Request #211 · aboutcode-org/fetchcode ConversationOlder npm releases currently inherit the registry document's top-level license, even when their own metadata specifies another license. Prefer the selected release's license, keeping the existing fallback when it is absent. Adds a regression with releases under different licenses.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsSigned-off-by: Ali Zulfiqar <[email protected]>
k-charansai
added a commit
to k-charansai/fetchcode
that referenced
this pull request
In get_npm_data_from_purl, declared_license was unconditionally set to the
top-level registry document's license, causing older or re-licensed package
versions to incorrectly inherit the package-level license.
Read declared_license from version.get('license') first, falling back to
the top-level license when absent or null. Add regression test covering
per-version license resolution and fallback behavior.
Closes aboutcode-org#211
Signed-off-by: k-charansai <[email protected]>
k-charansai
added a commit
to k-charansai/fetchcode
that referenced
this pull request
In get_npm_data_from_purl, declared_license was unconditionally set to the
top-level registry document's license, causing older or re-licensed package
versions to incorrectly inherit the package-level license.
Read declared_license from version.get('license') first, falling back to
the top-level license when absent or null. Add regression test covering
per-version license resolution and fallback behavior.
Closes aboutcode-org#211
Signed-off-by: k-charansai <[email protected]>
This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. 1 participantAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |