GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix overriding request options from @actions/github by luketomlinson · Pull Request #293 · actions/github-script

Conversation

@luketomlinson

@luketomlinson luketomlinson commented Sep 30, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Problem

Since introducing retries in #288, we would override the request field of the OctokitOptions we pass into the getOctokit method. The problem is that the @actions/github package also provides some defaults for the request field. source. Some users rely on these defaults and would break since we added retries.

Behavior:

If we have these defaults:

{
  request: {
    agent: 'some-agent'
  }
}

and add these options:

{
  request: {
    retries: 2
  }
}

we get the following output:

{
  request: {
    retries: 2
  }
}

Note the original options are completely overriden, which is not desired.

Solution

We copy the default options.request fields from the @actions/github package into the request field when we add the retries field.

Fixed behavior:

if we have these defaults:

{
  request: {
    agent: 'some-agent'
  }
}

and add these options:

{
  request: {
    retries: 2
  }
}

we get the following output:

{
  request: {
    agent: 'some-agent',
    retries: 2
  }
}

fixes #291

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@luketomlinson
luketomlinson requested a review from a team September 30, 2022 18:59
@luketomlinson
luketomlinson force-pushed the main branch from 327307e to 97ee88d Compare September 30, 2022 19:11
@luketomlinson
Fix overriding request options from @actions/github
8445ca8
@luketomlinson
luketomlinson force-pushed the main branch from fbf6376 to 8445ca8 Compare September 30, 2022 19:15
joshmgross
joshmgross approved these changes Sep 30, 2022
View reviewed changes
@joshmgross
joshmgross merged commit 7dff1a8 into actions:main Sep 30, 2022
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Oct 4, 2022
@desrosj
Build/Test Tools: Update github-script action to the latest version.
074a0ab 
The latest version of the `actions/github-script` action fixes an issue where passing options to the action would remove any default values not passed (see actions/github-script#293).

This also includes updates to other third-party actions, bringing all third-party versions in Core workflows to their latest versions:
- `actions/cache`
- `actions/setup-node`
- `codecov/codecov-action`

See #55652.

git-svn-id: https://develop.svn.wordpress.org/trunk@54373 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Oct 4, 2022
@desrosj
Build/Test Tools: Update github-script action to the latest version.
ac5a804 
The latest version of the `actions/github-script` action fixes an issue where passing options to the action would remove any default values not passed (see actions/github-script#293).

This also includes updates to other third-party actions, bringing all third-party versions in Core workflows to their latest versions:
- `actions/cache`
- `actions/setup-node`
- `codecov/codecov-action`

See #55652.
Built from https://develop.svn.wordpress.org/trunk@54373


git-svn-id: http://core.svn.wordpress.org/trunk@53932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions Bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Oct 4, 2022
@desrosj
Build/Test Tools: Update github-script action to the latest version.
749fe90 
The latest version of the `actions/github-script` action fixes an issue where passing options to the action would remove any default values not passed (see actions/github-script#293).

This also includes updates to other third-party actions, bringing all third-party versions in Core workflows to their latest versions:
- `actions/cache`
- `actions/setup-node`
- `codecov/codecov-action`

See #55652.
Built from https://develop.svn.wordpress.org/trunk@54373


git-svn-id: https://core.svn.wordpress.org/trunk@53932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
fuxingloh referenced this pull request in DeFiCh/metachain Oct 12, 2022
@renovate
bump(deps): update actions/github-script action to v6.3.2 (#111)
4763561 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/github-script](https://togithub.com/actions/github-script) |
action | minor | `v6.2.0` -> `v6.3.2` |

---

### Release Notes

<details>
<summary>actions/github-script</summary>

###
[`v6.3.2`](https://togithub.com/actions/github-script/releases/tag/v6.3.2)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.3.1...v6.3.2)

##### What's Changed

- Update [@&#8203;actions/core](https://togithub.com/actions/core) to
1.10.0 by [@&#8203;rentziass](https://togithub.com/rentziass) in
[https://github.com/actions/github-script/pull/295](https://togithub.com/actions/github-script/pull/295)

##### New Contributors

- [@&#8203;rentziass](https://togithub.com/rentziass) made their first
contribution in
[https://github.com/actions/github-script/pull/295](https://togithub.com/actions/github-script/pull/295)

**Full Changelog**:
actions/github-script@v6.3.1...v6.3.2

###
[`v6.3.1`](https://togithub.com/actions/github-script/releases/tag/v6.3.1)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.3.0...v6.3.1)

#### What's Changed

- Fix overriding request options from
[@&#8203;actions/github](https://togithub.com/actions/github) by
[@&#8203;luketomlinson](https://togithub.com/luketomlinson) in
[https://github.com/actions/github-script/pull/293](https://togithub.com/actions/github-script/pull/293)

**Full Changelog**:
actions/github-script@v6.3.0...v6.3.1

###
[`v6.3.0`](https://togithub.com/actions/github-script/releases/tag/v6.3.0)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.2.0...v6.3.0)

#### What's Changed

- Add retry plugin and related options by
[@&#8203;luketomlinson](https://togithub.com/luketomlinson) in
[https://github.com/actions/github-script/pull/288](https://togithub.com/actions/github-script/pull/288),
see https://github.com/actions/github-script/tree/v6.3.0#retries for
more information.

#### New Contributors

- [@&#8203;luketomlinson](https://togithub.com/luketomlinson) made their
first contribution in
[https://github.com/actions/github-script/pull/288](https://togithub.com/actions/github-script/pull/288)

**Full Changelog**:
actions/github-script@v6.2.0...v6.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/DeFiCh/metachain).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIzMi4wIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
desrosj added a commit to desrosj/wordpress-develop that referenced this pull request Oct 21, 2022
@desrosj
Build/Test Tools: Update github-script action to the latest version.
b58377f 
The latest version of the `actions/github-script` action fixes an issue where passing options to the action would remove any default values not passed (see actions/github-script#293).

This also includes updates to other third-party actions, bringing all third-party versions in Core workflows to their latest versions:
- `actions/cache`
- `actions/setup-node`
- `codecov/codecov-action`

See #55652.

git-svn-id: https://develop.svn.wordpress.org/trunk@54373 602fd350-edb4-49c9-b593-d223f7449a82
ootwch pushed a commit to ootwch/wordpress-develop that referenced this pull request Nov 4, 2022
@desrosj =
Build/Test Tools: Update github-script action to the latest version.
31daf35 
The latest version of the `actions/github-script` action fixes an issue where passing options to the action would remove any default values not passed (see actions/github-script#293).

This also includes updates to other third-party actions, bringing all third-party versions in Core workflows to their latest versions:
- `actions/cache`
- `actions/setup-node`
- `codecov/codecov-action`

See #55652.

git-svn-id: https://develop.svn.wordpress.org/trunk@54373 602fd350-edb4-49c9-b593-d223f7449a82
desrosj added a commit to desrosj/wordpress-develop that referenced this pull request Nov 18, 2022
@desrosj
Build/Test Tools: Update github-script action to the latest version.
95cfa41 
The latest version of the `actions/github-script` action fixes an issue where passing options to the action would remove any default values not passed (see actions/github-script#293).

This also includes updates to other third-party actions, bringing all third-party versions in Core workflows to their latest versions:
- `actions/cache`
- `actions/setup-node`
- `codecov/codecov-action`

See #55652.

git-svn-id: https://develop.svn.wordpress.org/trunk@54373 602fd350-edb4-49c9-b593-d223f7449a82
(cherry picked from commit 074a0ab)
desrosj added a commit to desrosj/wordpress-develop that referenced this pull request Nov 18, 2022
@desrosj
Build/Test Tools: Update github-script action to the latest version.
ec143e2 
The latest version of the `actions/github-script` action fixes an issue where passing options to the action would remove any default values not passed (see actions/github-script#293).

This also includes updates to other third-party actions, bringing all third-party versions in Core workflows to their latest versions:
- `actions/cache`
- `actions/setup-node`
- `codecov/codecov-action`

See #55652.

git-svn-id: https://develop.svn.wordpress.org/trunk@54373 602fd350-edb4-49c9-b593-d223f7449a82
(cherry picked from commit 074a0ab)
desrosj added a commit to desrosj/wordpress-develop that referenced this pull request Mar 6, 2023
@desrosj
Build/Test Tools: Update github-script action to the latest version.
a6c5845 
The latest version of the `actions/github-script` action fixes an issue where passing options to the action would remove any default values not passed (see actions/github-script#293).

This also includes updates to other third-party actions, bringing all third-party versions in Core workflows to their latest versions:
- `actions/cache`
- `actions/setup-node`
- `codecov/codecov-action`

See #55652.

git-svn-id: https://develop.svn.wordpress.org/trunk@54373 602fd350-edb4-49c9-b593-d223f7449a82
desrosj added a commit to desrosj/wordpress-develop that referenced this pull request Mar 6, 2023
@desrosj
Build/Test Tools: Update github-script action to the latest version.
b66eeb7 
The latest version of the `actions/github-script` action fixes an issue where passing options to the action would remove any default values not passed (see actions/github-script#293).

This also includes updates to other third-party actions, bringing all third-party versions in Core workflows to their latest versions:
- `actions/cache`
- `actions/setup-node`
- `codecov/codecov-action`

See #55652.

git-svn-id: https://develop.svn.wordpress.org/trunk@54373 602fd350-edb4-49c9-b593-d223f7449a82
desrosj added a commit to desrosj/wordpress-develop that referenced this pull request Mar 8, 2023
@desrosj
Build/Test Tools: Update github-script action to the latest version.
83c3745 
The latest version of the `actions/github-script` action fixes an issue where passing options to the action would remove any default values not passed (see actions/github-script#293).

This also includes updates to other third-party actions, bringing all third-party versions in Core workflows to their latest versions:
- `actions/cache`
- `actions/setup-node`
- `codecov/codecov-action`

See #55652.

git-svn-id: https://develop.svn.wordpress.org/trunk@54373 602fd350-edb4-49c9-b593-d223f7449a82
desrosj added a commit to desrosj/wordpress-develop that referenced this pull request Mar 8, 2023
@desrosj
Build/Test Tools: Update github-script action to the latest version.
49f2496 
The latest version of the `actions/github-script` action fixes an issue where passing options to the action would remove any default values not passed (see actions/github-script#293).

This also includes updates to other third-party actions, bringing all third-party versions in Core workflows to their latest versions:
- `actions/cache`
- `actions/setup-node`
- `codecov/codecov-action`

See #55652.

git-svn-id: https://develop.svn.wordpress.org/trunk@54373 602fd350-edb4-49c9-b593-d223f7449a82
desrosj added a commit to desrosj/wordpress-develop that referenced this pull request Mar 8, 2023
@desrosj
Build/Test Tools: Update github-script action to the latest version.
459d263 
The latest version of the `actions/github-script` action fixes an issue where passing options to the action would remove any default values not passed (see actions/github-script#293).

This also includes updates to other third-party actions, bringing all third-party versions in Core workflows to their latest versions:
- `actions/cache`
- `actions/setup-node`
- `codecov/codecov-action`

See #55652.

git-svn-id: https://develop.svn.wordpress.org/trunk@54373 602fd350-edb4-49c9-b593-d223f7449a82
desrosj added a commit to desrosj/wordpress-develop that referenced this pull request Mar 8, 2023
@desrosj
Build/Test Tools: Update github-script action to the latest version.
27c8ad1 
The latest version of the `actions/github-script` action fixes an issue where passing options to the action would remove any default values not passed (see actions/github-script#293).

This also includes updates to other third-party actions, bringing all third-party versions in Core workflows to their latest versions:
- `actions/cache`
- `actions/setup-node`
- `codecov/codecov-action`

See #55652.

git-svn-id: https://develop.svn.wordpress.org/trunk@54373 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@joshmgross joshmgross joshmgross approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Current version (6.3.0) is overriding proxy configuration

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@luketomlinson @joshmgross
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.