GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Upgrade @actions/github to v9 and @octokit/core to v7+ by Copilot · Pull Request #708 · actions/github-script Conversation
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was an error while loading. Please reload this page.
| Package | Old | New |
|---|---|---|
@actions/github |
^6.0.0 |
^9.0.0 |
@octokit/core |
^5.0.1 |
^7.0.0 |
@octokit/plugin-request-log |
^4.0.0 |
^6.0.0 |
@octokit/plugin-retry |
^6.0.1 |
^8.0.0 |
tsconfig.json)moduleResolution: "bundler" — required for ESM exports map resolution in @octokit/core v7 and @actions/github v9module: "es2022" — required by bundler resolutiontarget: "es2022" — needed for ErrorOptions type used in @octokit/request-errormodule: "commonjs" override to preserve CJS test executionsrc/retry-options.ts: @octokit/core/dist-types/types → @octokit/core/types (v7 subpath export)src/async-function.ts: @actions/github/lib/context is no longer in the v9 exports map. Replaced with typeof context derived from @actions/github/lib/utils:// Before import {Context} from '@actions/github/lib/context' import {GitHub} from '@actions/github/lib/utils' // ... context: Context // After import {context as _ghContext, GitHub} from '@actions/github/lib/utils' // ... context: typeof _ghContext
Updated build:types to pass --target es2022 --module es2022 --moduleResolution bundler since it specifies files directly (bypasses tsconfig.json).
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
- @actions/github: ^6.0.0 → ^9.0.0 - @octokit/core: ^5.0.1 → ^7.0.0 - @octokit/plugin-request-log: ^4.0.0 → ^6.0.0 - @octokit/plugin-retry: ^6.0.1 → ^8.0.0 - Update tsconfig.json to use moduleResolution: "bundler" for ESM exports map support - Update import paths for new package structures - Update build:types script for compatible compiler options Co-authored-by: angel-jiakou <[email protected]> Agent-Logs-Url: https://github.com/actions/github-script/sessions/17de5ca1-8bdc-41e4-a06d-ab2d8c2e6e8c
There was an error while loading. Please reload this page.
|
Hello from actions/github-script! (2f6961d) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Upgrades the Action’s GitHub/Octokit dependencies to ESM-only major versions and updates the TypeScript + test/build configuration and import paths to remain compatible.
Changes:
@actions/github to v9 and @octokit/* dependencies to their v6/v7/v8 major versions.target/module es2022, moduleResolution: bundler) and adjust ts-jest to keep tests running in CJS.exports maps and relax integration workflow user-agent assertions.Copilot reviewed 28 out of 34 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| types/async-function.d.ts | Updates exported argument types to avoid removed @actions/github/lib/context path. |
| tsconfig.json | Switches project TS target/module to ES2022 and module resolution to bundler. |
| src/retry-options.ts | Updates Octokit type import to the new v7 exported subpath. |
| src/async-function.ts | Adjusts context typing approach to match @actions/github v9 export map changes. |
| package.json | Bumps deps, updates build:types, and adds ts-jest TS overrides. |
| package-lock.json | Lockfile updates for the new dependency graph and transitive packages. |
| .licenses/npm/wrappy.dep.yml | Removes cached license entry (dependency no longer in licensed set). |
| .licenses/npm/universal-user-agent.dep.yml | Updates cached license metadata version for transitive bump. |
| .licenses/npm/undici-6.24.1.dep.yml | Corrects cached license metadata to match [email protected]. |
| .licenses/npm/undici-5.28.5.dep.yml | Adds cached license metadata for [email protected]. |
| .licenses/npm/once.dep.yml | Removes cached license entry (dependency no longer in licensed set). |
| .licenses/npm/json-with-bigint.dep.yml | Adds cached license metadata for new transitive dependency. |
| .licenses/npm/fast-content-type-parse.dep.yml | Adds cached license metadata for new transitive dependency. |
| .licenses/npm/deprecation.dep.yml | Removes cached license entry (dependency removed from graph). |
| .licenses/npm/before-after-hook.dep.yml | Updates cached license metadata version for transitive bump. |
| .licenses/npm/@octokit/types.dep.yml | Updates cached license metadata version for transitive bump. |
| .licenses/npm/@octokit/types-12.0.0.dep.yml | Removes cached license entry for superseded version. |
| .licenses/npm/@octokit/request.dep.yml | Updates cached license metadata version for transitive bump. |
| .licenses/npm/@octokit/request-error.dep.yml | Updates cached license metadata version for transitive bump. |
| .licenses/npm/@octokit/plugin-retry.dep.yml | Updates cached license metadata version for transitive bump. |
| .licenses/npm/@octokit/plugin-rest-endpoint-methods.dep.yml | Updates cached license metadata version for transitive bump. |
| .licenses/npm/@octokit/plugin-request-log.dep.yml | Updates cached license metadata version for transitive bump. |
| .licenses/npm/@octokit/plugin-paginate-rest.dep.yml | Updates cached license metadata version for transitive bump. |
| .licenses/npm/@octokit/openapi-types.dep.yml | Updates cached license metadata version for transitive bump. |
| .licenses/npm/@octokit/openapi-types-19.0.0.dep.yml | Removes cached license entry for superseded version. |
| .licenses/npm/@octokit/graphql.dep.yml | Updates cached license metadata version for transitive bump. |
| .licenses/npm/@octokit/endpoint.dep.yml | Updates cached license metadata version for transitive bump. |
| .licenses/npm/@octokit/core.dep.yml | Updates cached license metadata version for direct dependency bump. |
| .licenses/npm/@octokit/auth-token.dep.yml | Updates cached license metadata version for transitive bump. |
| .licenses/npm/@actions/http-client-3.0.2.dep.yml | Adds cached license metadata for new transitive version. |
| .licenses/npm/@actions/http-client-2.2.0.dep.yml | Adds cached license metadata for existing transitive version. |
| .licenses/npm/@actions/github.dep.yml | Updates cached license metadata version for direct dependency bump. |
| .github/workflows/integration.yml | Adjusts user-agent integration assertions to allow the new user-agent format. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| import {context as _ghContext, GitHub} from '@actions/github/lib/utils' | ||
| import * as glob from '@actions/glob' |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
@actions/github/lib/utils is a deep import that isn’t part of the stable public API surface and has already changed once (lib/context disappeared in v9). Since this import is only used to derive types, prefer using public exports from @actions/github (e.g., typeof context for context and ReturnType<typeof getOctokit> for github/octokit) and make the import type-only so it can’t accidentally become a runtime dependency.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I think this comment is valid so I'm gonna make these public exports in case this import changes again.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks fine so far but I'd upgrade all the Actions packages instead of just a few.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| @@ -40,12 +45,12 @@ | |||
| "dependencies": { | |||
| "@actions/core": "^1.10.1", | |||
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
All the @actions/* packages have been upgraded, I would pick up those new versions as well.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Hold — requires changes in main first to add a wrapper for getOctokit
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Merges the @actions/github v9 upgrade branch into the createOctokit feature branch, combining ADR steps 1 and 3 into a single major release. Changes from v9 upgrade: - @actions/github 6.x → 9.0.0 (ESM-only) - @octokit/core v5→v7, plugin-request-log v4→v6, plugin-retry v6→v8 - tsconfig: moduleResolution bundler, module/target es2022 - ts-jest: module commonjs override for CJS test execution - License file updates for new dependency versions Conflict resolutions: - src/async-function.ts: v9 import style + createOctokit type - types/async-function.d.ts: aligned with .ts file - integration.yml: v9 UA checks + createOctokit test job - dist/index.js: rebuilt via ncc Additional fix: - getoctokit-integration.test.ts: use mock instead of direct @actions/github import (ESM-only v9 incompatible with Jest CJS) All 32 tests passing, TypeScript clean, lint clean.
|
Closing in favour of #700 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
c1a95771
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Upgrade @actions/github to v9 and @octokit/core to v7+
There was an error while loading. Please reload this page.