GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add warning if python version set to empty value by dsame · Pull Request #396 · actions/setup-python

Conversation

@dsame

@dsame dsame commented Apr 29, 2022

Copy link
Copy Markdown
Contributor

Description:
There was a request to add non-zero exit in case if python-version input set to zero value, but @dmitry-shibanov warned it might break the existing builds.

I suggest to add a warning to the log instead of of non-zero exit code.

There's a build confirming no tool-cache python installed if python-version is empty.

Related issue:
related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@dsame
Add warning if python version set to empty value
ac4e858
@dsame
dsame requested a review from a team April 29, 2022 04:28
@dsame
Add generated files
22daa09
marko-zivic-93
marko-zivic-93 reviewed Apr 29, 2022
View reviewed changes
Comment thread src/setup-python.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

marko-zivic-93
marko-zivic-93 approved these changes Apr 29, 2022
View reviewed changes
@dsame dsame mentioned this pull request Apr 29, 2022
Zero exit with empty input for python-version #241
Closed
@dsame
Improve wording
0b56b76
marko-zivic-93
marko-zivic-93 approved these changes Apr 29, 2022
View reviewed changes
brcrista
brcrista reviewed Apr 29, 2022
View reviewed changes
Comment thread src/setup-python.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

dsame and others added 2 commits May 4, 2022 12:43
@dsame @brcrista
Improve warning message
e31727c
Co-authored-by: Brian Cristante <[email protected]>
@dsame
Formatting
8f73c14
marko-zivic-93
marko-zivic-93 approved these changes May 4, 2022
View reviewed changes
vsafonkin
vsafonkin approved these changes May 4, 2022
View reviewed changes
brcrista
brcrista approved these changes May 4, 2022
View reviewed changes
@marko-zivic-93
marko-zivic-93 merged commit fd8f0a9 into actions:main May 4, 2022
@dsame
dsame deleted the v-sedoli/issue-241 branch May 5, 2022 06:33
@kmasuda050 kmasuda050 mentioned this pull request Apr 18, 2025
Throwing an error when python-version input is empty and PYTHON_VERSION_REQUIRED is set true #1088
Open
2 tasks done
tdfacer pushed a commit to ifit/setup-python that referenced this pull request Oct 7, 2025
@marko-zivic-93
Merge pull request actions#396 from akv-platform/v-sedoli/issue-241
064f743
Add warning if python version set to empty value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@vsafonkin vsafonkin vsafonkin approved these changes
@brcrista brcrista brcrista approved these changes
@marko-zivic-93 marko-zivic-93 marko-zivic-93 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@dsame @vsafonkin @brcrista @marko-zivic-93
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.