GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — Add `cache-save: false` option by akx · Pull Request #762 · actions/setup-python Conversation
|
|
Rebased on v5. @dmitry-shibanov Could you review this, please? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Could someone please take an action for this PR and release a new version? 🙏 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@akx can you request review from the maintainers here? @priya-kinthali @aparnajyothi-y @HarithaVattikuti |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@ozancaglayan As an external, I have no option to request a reviewer. GitHub does say "actions/setup-actions-team was requested for review"... |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Also remove setup-python caching hacks. Refs: actions/setup-python#807 actions/setup-python#762 actions/setup-python#751 Reverts: 662a971 89d73b1 e8ef6db f65666c
There was an error while loading. Please reload this page.
|
Hello Everyone, Thank you for your contribution with this PR. We truly appreciate your understanding and patience, and we encourage you to continue sharing any further thoughts or suggestions you may have. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hello @akx, Please let us know if you still need any more clarifications/concerns on the above. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
It's opt-in, for corner cases as described in the PR description.
Yes, perfectly on purpose, as described in the PR description.
Any change or improvement does that, really. Do note that this PR does have tests and documentation included. @aparnajyothi-y Feel free to close this if you still believe it's not welcome. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This would also allow using the cache while avoiding cache poisoning vulnerabilities from PRs: - uses: actions/setup-python@v5 with: python-version: "3.13" cache: "pip" # For anything PR-related, treat the cache as restore-only: cache-save: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} Without this option, workflow security audits currently recommend removing |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
For people following at home, |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.