Description

Sup3rGeo

opened on May 14, 2018

Issue body actions

I'm submitting a ...

• bug report
• feature request
• support request => Please do not submit support request here, see note at the top of this template.

What is the current behavior?

Parametrizing a test creates container json files for the parametrized parameter that doesn't seem to be used at all, as it does not have a children node.

It does not appear on the setup section of the tests, which is not a big problem as the parametrization for each test instance is written inside the result json itself.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

import pytest


@pytest.mark.parametrize("message",[
    "a",
    "b"
])
def test1(message):
    assert 1 == 1

What is the expected behavior?

Add a children node to the created container json files, so parametrization appears on setup, or don't create a container json for test parametrization at all.

What is the motivation / use case for changing the behavior?

Have a consistent behavior and do not create files if not needed.

Please tell us about your environment:

• Allure version: 2.6.0
• Test framework: [email protected]
• Allure adaptor: [email protected]

Other information

Reacted by Dmitry Makhrovsky

Activity

1. Sup3rGeo commented on May 14, 2018

   

   Sup3rGeo

   on May 14, 2018

   ContributorAuthor

   More actions

   @sseliverstov what do we want to do in this case?
2. Sup3rGeo

   changed the title [-]Test parametrization creates json orphan container json files[/-] [+]Test parametrization creates orphan container json files[/+] on May 16, 2018
3. sseliverstov commented on May 20, 2018

   

   sseliverstov

   on May 20, 2018

   Contributor

   More actions

   fixed
4. sseliverstov

   closed this as completedon May 20, 2018
5. sseliverstov

   added a commit that references this issue on May 21, 2018

   Wrong attachments for parameterized (fixes #207 fixes #223 via #228)

   This issue will close once commit 0d28836 is merged into the 'master' branch.

   0d28836
6. Sup3rGeo commented on May 22, 2018

   

   Sup3rGeo

   on May 22, 2018

   ContributorAuthor

   More actions

   In a very simple test like

   import pytest
   
   
   @pytest.mark.parametrize("param", [1,2,3])
   def test_simples(param):
       return
   

   I still get containers:

   {
   	"uuid": "4e3e905d-7bb7-49ce-8290-eb6636ec4574",
   	"befores": [
   		{
   			"name": "param",
   			"status": "passed",
   			"start": 1527003413912,
   			"stop": 1527003413912
   		}
   	],
   	"start": 1527003413912,
   	"stop": 1527003413912
   }
   
7. sseliverstov commented on May 23, 2018

   

   sseliverstov

   on May 23, 2018

   Contributor

   More actions

   @Sup3rGeo if it reproduced for 2.3.3b1, please reopen this issue

   Reacted by Dmytro Makhno
8. beckerGil

   added a commit that references this issue on Apr 10, 2023

   Wrong attachments for parameterized (fixes allure-framework#207 fixes a…

   This issue will close once commit 88c32fd is merged into the 'master' branch.

   88c32fd
9. IvanBuruyane

   added a commit that references this issue on Mar 19, 2024

   Wrong attachments for parameterized (fixes allure-framework#207 fixes a…

   This issue will close once commit b7607f1 is merged into the 'master' branch.

   b7607f1

Issue actions