GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — added @allure.title annotation support for fixtures by rad96 · Pull Request #527 · allure-framework/allure-python

Conversation

@rad96

@rad96 rad96 commented Dec 1, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #210

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@rad96

rad96 commented Dec 1, 2020

Copy link
Copy Markdown
Contributor Author

image

tested it with allure-ee and free allure, works as expected

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sseliverstov

sseliverstov commented Dec 2, 2020

Copy link
Copy Markdown
Contributor
  1. Please, add tests for this improvement.
  2. allure.title ads pytest mark to fixture function. It is unused by pytest framework but can be useful for getting given title from function attribute (see pytest code). Please, use this machinery instead of code inspection.
    Tnx!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rad96

rad96 commented Dec 2, 2020

Copy link
Copy Markdown
Contributor Author
  1. Please, add tests for this improvement.
  2. allure.title ads pytest mark to fixture function. It is unused by pytest framework but can be useful for getting given title from function attribute (see pytest code). Please, use this machinery instead of code inspection.
    Tnx!

@sseliverstov

  1. Added tests in PR
  2. I checked out how pytest manage marks for fixtures and, for me, looks like pytest don't support it in any way. Maybe my knowledge of pytest is not enough :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rad96

rad96 commented Dec 2, 2020

Copy link
Copy Markdown
Contributor Author

Maybe we can use that solution temporary, and make issue for changing it?
Because, at least, that solution works, and issue was here for 2 years

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rad96

rad96 commented Dec 2, 2020

Copy link
Copy Markdown
Contributor Author
  1. Please, add tests for this improvement.
  2. allure.title ads pytest mark to fixture function. It is unused by pytest framework but can be useful for getting given title from function attribute (see pytest code). Please, use this machinery instead of code inspection.
    Tnx!

Also found this in pytest issues, looks like markers don't work with fixtures right now:
pytest-dev/pytest#3960 (comment)

image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Artem Ryabkov and others added 3 commits December 7, 2020 01:04
Artem Ryabkov
Titled fixtures and tests for them
f6a6f6a
Artem Ryabkov
Splited helper
373bb6d
Artem Ryabkov
Cleaned up, added comments
5e93c97
sseliverstov
sseliverstov approved these changes Dec 6, 2020
View reviewed changes
@sseliverstov
sseliverstov merged commit ed38912 into allure-framework:master Dec 6, 2020
@sseliverstov

sseliverstov commented Dec 6, 2020

Copy link
Copy Markdown
Contributor

Thank you @rad96

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@delatrie delatrie mentioned this pull request Dec 26, 2022
BUG - Breaking change with allure.title annotations in 2.8.24 #536
Closed
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
Artem Ryabkov @GilBecker-Anaplan
added @allure.title annotation support for fixtures (fixes allure-fra…
c4d4034
…mework#210 via allure-framework#527)
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
Artem Ryabkov @GilBecker-Anaplan
added @allure.title annotation support for fixtures (fixes allure-fra…
de6c243
…mework#210 via allure-framework#527)
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
Artem Ryabkov
added @allure.title annotation support for fixtures (fixes allure-fra…
330afa1
…mework#210 via allure-framework#527)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sseliverstov sseliverstov sseliverstov approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support allure.title decorator for fixtures

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rad96 @sseliverstov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.