GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix missing fixtures in report when using lazy_fixture by dgusakov · Pull Request #548 · allure-framework/allure-python

Conversation

@dgusakov

@dgusakov dgusakov commented Jan 20, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There is a well known issue with missing fixtures in allure-report when using lazy_fixture plugin

Since during runtime fixtures can be added to item._request.fixturenames it looks reasonable to take fixturenames list from here and not from item.fixturenames where fixturenames are filled only at the built-in pytest collect stage.

Checklist

  • Sign Allure CLA
  • Provide unit tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
dgusakov
Fix missing fixtures in report when using lazy_fixture
f42a6f6
@CLAassistant

CLAassistant commented Jan 20, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dgusakov added 5 commits January 25, 2021 15:42
dgusakov
Add tests for lazy_fixture integration
fbd07f5
dgusakov
Fix newline
4687412
dgusakov
Fix tests
c8d6d3a
dgusakov
Revert develop changes
9ac84cb
dgusakov
Fix unused import
b324e96
sseliverstov
sseliverstov approved these changes Jan 25, 2021
View reviewed changes
@sseliverstov
sseliverstov merged commit 6e7fe49 into allure-framework:master Jan 25, 2021
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
@dgusakov @GilBecker-Anaplan
Fix missing fixtures in report when using lazy_fixture (via allure-fr…
793a783 
…amework#548)
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
@dgusakov @GilBecker-Anaplan
Fix missing fixtures in report when using lazy_fixture (via allure-fr…
5aad4fe 
…amework#548)
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
@dgusakov
Fix missing fixtures in report when using lazy_fixture (via allure-fr…
950798b 
…amework#548)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sseliverstov sseliverstov sseliverstov approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@dgusakov @CLAassistant @sseliverstov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.