GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add an ability to pass positional args as keyword (fixes #440) by Denis-Alexeev · Pull Request #569 · allure-framework/allure-python

Conversation

@Denis-Alexeev

@Denis-Alexeev Denis-Alexeev commented Mar 3, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

fixes #440

Context

When allure.step decorates function with positional and keyword args, then allure fails with KeyError if any positional argument was passed as keyword argument during function call.

Checklist

  • [Sign Allure CLA][cla]
  • Provide unit tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Denis Alexeev
issue-440
9bdc82b
@CLAassistant

CLAassistant commented Mar 3, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Denis-Alexeev Denis-Alexeev changed the title Add an ability to pass positional args as keyword (fixes #440) Add an ability to pass positional args as keyword (fixes #440\) Mar 3, 2021
@Denis-Alexeev Denis-Alexeev changed the title Add an ability to pass positional args as keyword (fixes #440\) Add an ability to pass positional args as keyword (fixes #440) Mar 3, 2021
@Denis-Alexeev Denis-Alexeev mentioned this pull request Mar 3, 2021
@allure.step decorator fails if one of the method parameters has a default value #440
Closed
Denis Alexeev
issue-440 (delete redundant code)
1565459
@Denis-Alexeev

Denis-Alexeev commented Mar 16, 2021

Copy link
Copy Markdown
Contributor Author

Hello, Guys! Could you please take a look and review the changes?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sseliverstov

sseliverstov commented Mar 22, 2021

Copy link
Copy Markdown
Contributor

@Denis-Alexeev Thank you for your contribution, can you update branch please?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Denis Alexeev
Merge pull request #1 from allure-framework/master
38b8210 
Updating forked master
@Denis-Alexeev

Denis-Alexeev commented Mar 22, 2021

Copy link
Copy Markdown
Contributor Author

@sseliverstov Done.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Denis-Alexeev

Denis-Alexeev commented May 17, 2021

Copy link
Copy Markdown
Contributor Author

Hello, Guys! Could you please take a look and review the changes?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sseliverstov
sseliverstov approved these changes May 19, 2021
View reviewed changes
@sseliverstov
sseliverstov merged commit b2e64d4 into allure-framework:master May 19, 2021
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
Denis Alexeev @GilBecker-Anaplan
Add an ability to pass positional args as keyword (fixes allure-frame…
d21a2bf 
…work#440) (allure-framework#569)
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
Denis Alexeev
Add an ability to pass positional args as keyword (fixes allure-frame…
6a59bea 
…work#440) (allure-framework#569)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sseliverstov sseliverstov sseliverstov approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@allure.step decorator fails if one of the method parameters has a default value

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Denis-Alexeev @CLAassistant @sseliverstov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.