GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix duplicated fixtures after 2.11.0 release by skhomuti · Pull Request #696 · allure-framework/allure-python

Conversation

@skhomuti

@skhomuti skhomuti commented Oct 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

No need to update fixtures in test teardown because all fixtures are already finished at this moment and no way to run they again

Fixes #695

Context

Checklist

  • Sign Allure CLA
  • Provide unit tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skhomuti
No need to update fixtures in test teardown because all fixtures are …
f43e42b 
…already finished at this moment and no way to run they again
@skhomuti
skhomuti force-pushed the duplicate-fixture-fix branch from 064865b to f43e42b Compare October 11, 2022 15:45
ShurikMen
ShurikMen approved these changes Oct 11, 2022
View reviewed changes
ShurikMen
ShurikMen approved these changes Oct 12, 2022
View reviewed changes
eroshenkoam
eroshenkoam approved these changes Oct 12, 2022
View reviewed changes
@skhomuti
skhomuti merged commit d0415af into master Oct 12, 2022
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
@skhomuti @GilBecker-Anaplan
No need to update fixtures in test teardown because all fixtures are …
24e19b5 
…already finished at this moment and no way to run they again (allure-framework#696)
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
@skhomuti
No need to update fixtures in test teardown because all fixtures are …
d7424c3 
…already finished at this moment and no way to run they again (allure-framework#696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eroshenkoam eroshenkoam eroshenkoam approved these changes
+1 more reviewer
@ShurikMen ShurikMen ShurikMen approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicated pytest fixtures

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@skhomuti @eroshenkoam @ShurikMen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.