GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix allure_full_name parsing when square bracers is in param contents by skhomuti · Pull Request #708 · allure-framework/allure-python

Conversation

@skhomuti

@skhomuti skhomuti commented Nov 22, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

fixes #622

also fix typo in test names

Context

Checklist

  • Sign Allure CLA
  • Provide unit tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
delatrie
delatrie requested changes Nov 23, 2022
View reviewed changes

@delatrie delatrie left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new allure_full_name algorithm is much nicer now, but it omits a dot before a class name:

image

I made some suggestions to fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread allure-pytest/src/utils.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread allure-pytest/test/acceptance/parametrization/parametrization_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@skhomuti
Fix allure_full_name parsing when square bracers is in param contents
8c5a792
@skhomuti
skhomuti requested a review from delatrie November 23, 2022 06:10
@skhomuti
skhomuti force-pushed the full_name_fix branch from ca3af86 to 8c5a792 Compare November 23, 2022 06:10
delatrie
delatrie approved these changes Nov 23, 2022
View reviewed changes
baev
baev approved these changes Nov 23, 2022
View reviewed changes
@baev
baev merged commit ed3a676 into master Nov 23, 2022
@baev
baev deleted the full_name_fix branch November 23, 2022 07:29
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
@skhomuti @GilBecker-Anaplan
fix allure_full_name parsing when square bracers is in param contents (…
cf4dded 
…fixes allure-framework#622, via allure-framework#708)
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
@skhomuti
fix allure_full_name parsing when square bracers is in param contents (…
8d20ce2 
…fixes allure-framework#622, via allure-framework#708)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baev baev baev approved these changes
@delatrie delatrie delatrie approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

incorrect allure_full_name parsing - testcase duplication in TestOps

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@skhomuti @baev @delatrie
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.