GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix squashed results when using rerunfailures (fixes #735) by delatrie · Pull Request #736 · allure-framework/allure-python

Conversation

@delatrie

@delatrie delatrie commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

Context

This PR fixes the regression when pytest-rerunfailures is used. The issue started to occur after the closing of a test result was moved from pytest_runtest_logfinish to pytest_runtest_protocol to prevent the test result from being omitted from the output under certain conditions (e.g., if pytest.exit was called during fixture setup).

To fix that, I put the closing of a test result back to pytest_runtest_logfinish while still backing it up with pytest_runtest_protocol in case pytest_runtest_logfinish is not called. These two closings should cover both issues.

Fixes #735.

Checklist

  • Sign Allure CLA
  • Provide unit tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@delatrie
Fix squashed results when using rerunfailures
478c7d9
@delatrie delatrie added bug Something isn't working theme:pytest labels Mar 13, 2023
@delatrie
delatrie requested a review from skhomuti March 13, 2023 17:19
@delatrie delatrie self-assigned this Mar 13, 2023
@delatrie
Fix linting errors
5cba8b2
skhomuti
skhomuti approved these changes Mar 14, 2023
View reviewed changes
@delatrie
Merge branch 'master' into issue735-fix
509f559
@delatrie
delatrie merged commit 12085cd into master Mar 14, 2023
@delatrie
delatrie deleted the issue735-fix branch March 14, 2023 12:57
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
@delatrie @GilBecker-Anaplan
Fix squashed results when using rerunfailures (fixes allure-framework…
607c23f 
…#735) (allure-framework#736)
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
@delatrie
Fix squashed results when using rerunfailures (fixes allure-framework…
a9f6e71 
…#735) (allure-framework#736)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@skhomuti skhomuti skhomuti approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@delatrie delatrie

Labels

bug Something isn't working theme:pytest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicated test case statuses reported with pytest-rerunfailures, retries section is empty

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@delatrie @skhomuti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.