GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix historyId calculation by allure-pytest (fix #743, #744) by delatrie · Pull Request #745 · allure-framework/allure-python

Conversation

@delatrie

@delatrie delatrie commented Apr 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Context

This PR fixes a couple of issues regarding historyId

  1. Allure-pytest now takes into account non-excluded dynamic parameters when calculating historyId.
  2. Assigning or changing an id of a pytest parameter set now doesn't affect historyId.
  3. Reordering of parameters (both pytest-provided and/or dynamic) now doesn't affect how allure-pytest calculates historyId.

Other changes

  1. allure_commons.utils.md5 now may take any value, not only strings.
  2. Add missed issue link to one of the tests.
  3. Fix pytest runner crash with an unhelpful AttributeError when trying to execute a non-existing docstring.

Checklist

  • Sign Allure CLA
  • Provide unit tests

Closes #743
Closes #744
Enables #430

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@delatrie
Fix historyId calculation by allure-pytest
ebf3fd1
@delatrie delatrie added bug Something isn't working theme:pytest labels Apr 23, 2023
@delatrie delatrie self-assigned this Apr 23, 2023
@delatrie
delatrie requested a review from skhomuti April 23, 2023 18:49
@delatrie
delatrie marked this pull request as ready for review April 24, 2023 07:42
skhomuti
skhomuti approved these changes Apr 26, 2023
View reviewed changes
@delatrie
Merge branch 'master' into i743-historyId-fix
0f419a7
@delatrie
delatrie merged commit 8e7b2ae into master Apr 26, 2023
@delatrie
delatrie deleted the i743-historyId-fix branch April 26, 2023 09:02
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
@delatrie
Fix historyId calculation by allure-pytest (fix allure-framework#743, a…
74b5733 
…llure-framework#744) (allure-framework#745)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@skhomuti skhomuti skhomuti approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@delatrie delatrie

Labels

bug Something isn't working theme:pytest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Changing an id of a pytest parameter set breaks test's history Fix historyId to be dependent on dynamic allure parameters

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@delatrie @skhomuti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.