GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Write Allure result files atomically by delatrie · Pull Request #924 · allure-framework/allure-python

Conversation

@delatrie

@delatrie delatrie commented Sep 18, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Context

The PR implements atomic writes: Allure result files are first written with the .tmp suffix then get renamed to their final names with os.replace.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@delatrie
feat(commons): atomic result write
9883a22
@delatrie delatrie added theme:core type:enhancement labels Sep 18, 2026
andrcuns
andrcuns approved these changes Sep 18, 2026
View reviewed changes
@delatrie
test(robot): remove console log from test case
315e376
@delatrie
delatrie force-pushed the atomic-write branch from 03d6221 to 315e376 Compare September 18, 2026 19:24
@delatrie
delatrie merged commit 5c72005 into master Sep 18, 2026
53 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@delatrie
delatrie deleted the atomic-write branch September 18, 2026 19:43
lorenzhs added a commit to firebolt-db/firebolt-python-sdk that referenced this pull request Oct 7, 2026
@lorenzhs
fix: exclude Allure report writer from fake filesystem
bf61f92 
Allure 2.16.1 introduced atomic report writes: io.open writes the
temporary file on the real filesystem, but pyfakefs intercepts
os.replace and searches the fake filesystem. Exclude the actual
Allure modules so both operations use the real filesystem.

Upstream: allure-framework/allure-python#924

Validation: Python 3.9.25, Allure 2.16.2, pyfakefs 5.6.0; full unit
suite with coverage and Allure enabled: 778 passed, 1 skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrcuns andrcuns andrcuns approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

theme:core type:enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@delatrie @andrcuns
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.