GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(benchpress): should still support selenium_webdriver < 3.6.0 by marclaval · Pull Request #21477 · angular/angular

Conversation

@marclaval

@marclaval marclaval commented Jan 11, 2018

Copy link
Copy Markdown
Contributor

Since #21399, benchmarks fail to run locally.
The reason root cause is how TS transpiles this new code. It is a known issue which was fixed in microsoft/TypeScript#12346 with a new option: downlevelIteration.

As discussed with @alexeagle, instead of changing our compiler options right now, we can also work around it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@marclaval
fix(benchpress): should still support selenium_webdriver < 3.6.0
8ef566b
@marclaval
marclaval requested a review from alexeagle January 11, 2018 17:53
@googlebot googlebot added the cla: yes label Jan 11, 2018
alexeagle
alexeagle approved these changes Jan 11, 2018
View reviewed changes
alxhub
alxhub approved these changes Jan 11, 2018
View reviewed changes
@alexeagle alexeagle added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jan 11, 2018
alexeagle pushed a commit that referenced this pull request Jan 11, 2018
@marclaval @alexeagle
fix(benchpress): should still support selenium_webdriver < 3.6.0 (#21477
3c6a506 
)

PR Close #21477
@alexeagle alexeagle closed this in 9b84a32 Jan 11, 2018
@warpech warpech mentioned this pull request Mar 25, 2019
Protractor with benchpress runner gives TypeError: capsObject.forEach is not a function #25139
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub alxhub approved these changes
+1 more reviewer
@alexeagle alexeagle alexeagle approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@marclaval @alexeagle @alxhub @googlebot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.