GeezerVison

Hi @agussman! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@agussman : Hi. Now that v6 is released, we're getting around to closing some open loops. I apologize for letting this sit for so long. If you're still interested, we'd be thrilled to have you contribute this fix. It's a bit out-of-date, as I think some PRs were merged that fixed some of the HTTPModule issues you were addressing. I think, however, there are still some areas that aren't fixed. I made a few notes on the original issue.

Is there anything I can do to help you make this contribution? Thanks!

@jenniferfell : Yes, I would like to contribute the PR. What is required from my end?

@agussman: Fantastic! The first thing I recommend doing is resolving conflicts between what we have in master and what you have in this PR. We just released v6 yesterday, so it's a good time. If you're familiar with github, there's nothing special about doing this with our example and doc files.

For some tips about how we merge changes from master into our doc-examples branches, my team started to collect some information:
https://github.com/ExpertSupport/doc-workflow/wiki/Daily-Startup (see step 2 especially)
https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

Hi @jenniferfell : I merged in the latest master, resolved conflicts, and updated the PR. Can you take a look and let me know if there are any issues that would prevent it from being merged? Thanks!

@IgorMinar Thank you for the code review!

@jenniferfell Anything else needed from me?

caretaker note: the failing CI tests seems like an unrelated flake. I restarted the job, but if that doesn't help please check on the failure and merge this PR.

@agussman I don't think so. I think the CI failure is unrelated to your change, so let's wait for the caretaker to investigate.

@agussman there is an issue with the changes causing the CI to fail. Could you please take a look.

@vicb: Happy to take a look, but per @IgorMinar's comment the CI failures don't appear to be related to these changes.

@agussman, there are still files that are importing from @angular/http (e.g. importing Http) and some of them are intentiinally doing so. You need to ensure that the examples e2e tests pass with any changes you make.

(We also nee to make sure that guide text is update (if necessary).)

@agussman will you rebase on master?

Closing in favor of smaller PRs already merged and in process

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}