GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(aio): fix errors after RxJS 6 migration by cexbrayat · Pull Request #22886 · angular/angular

Conversation

@cexbrayat

@cexbrayat cexbrayat commented Mar 20, 2018

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

@IgorMinar PR #22573 introduced a few weird things

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@googlebot googlebot added the cla: yes label Mar 20, 2018
@matsko matsko added area: core Issues related to the framework runtime comp: aio and removed area: core Issues related to the framework runtime labels Mar 22, 2018
@cexbrayat
fix(aio): fix error in import after RxJS 6 migration
537880c
@cexbrayat
cexbrayat force-pushed the fix/aio-import-error branch from 228aa4f to 537880c Compare April 18, 2018 06:25
@cexbrayat

cexbrayat commented Apr 18, 2018

Copy link
Copy Markdown
Member Author

Commit fe312cc from @brandonroberts fixed part of what this PR was covering, but there is still a slash remaining in an import after PR #22573 from @IgorMinar
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
petebacondarwin
petebacondarwin approved these changes May 9, 2018
View reviewed changes
@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label May 9, 2018
@ngbot

ngbot Bot commented May 9, 2018

Copy link
Copy Markdown

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required label: "PR target: *"
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@petebacondarwin

petebacondarwin commented May 9, 2018

Copy link
Copy Markdown
Contributor

The Travis flake is not related to this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@IgorMinar IgorMinar added the target: patch This PR is targeted for the next patch release label May 9, 2018
@IgorMinar IgorMinar closed this in e942d8b May 9, 2018
IgorMinar pushed a commit that referenced this pull request May 9, 2018
@cexbrayat @IgorMinar
fix(aio): fix error in import after RxJS 6 migration (#22886)
06776d1 
PR Close #22886
mashhoodr pushed a commit to mashhoodr/angular that referenced this pull request May 28, 2018
@cexbrayat @mashhoodr
fix(aio): fix error in import after RxJS 6 migration (angular#22886)
f598e21 
PR Close angular#22886
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@petebacondarwin petebacondarwin petebacondarwin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@cexbrayat @petebacondarwin @matsko @IgorMinar @googlebot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.