GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build(compiler-cli): update tsickle version by andrewseguin · Pull Request #23531 · angular/angular

Conversation

@andrewseguin

@andrewseguin andrewseguin commented Apr 24, 2018

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

Updating compiler-cli's tsickle version

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andrewseguin
build(compiler-cli): update tsickle version
c4dd049
@andrewseguin
andrewseguin requested a review from alxhub April 24, 2018 20:32
@googlebot googlebot added the cla: yes label Apr 24, 2018
@andrewseguin andrewseguin added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime and removed cla: yes labels Apr 24, 2018
@googlebot googlebot added the cla: yes label Apr 24, 2018
@andrewseguin andrewseguin mentioned this pull request Apr 24, 2018
[Table] Does not work when targetting ES6 angular/components#9329
Closed
@mary-poppins

mary-poppins commented Apr 24, 2018

Copy link
Copy Markdown

You can preview c4dd049 at https://pr23531-c4dd049.ngbuilds.io/.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@IgorMinar

IgorMinar commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

what's the motivation for this change? are the previous patch versions broken in a significant way that would want us to ensure we are using the latest? something else?

also if you don't update any lock files, we'll keep on using whatever we are currently using for our own tests, but since none of them are failing, it's really unclear what you are fixing, so more info would be appreciated. thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewseguin

andrewseguin commented Apr 26, 2018

Copy link
Copy Markdown
Contributor Author

The version is being updated to include this fix in tsickle: angular/tsickle#760

The issue is that when Material builds its es2015 files for distribution, it does not build the MatTable correctly. Tsickle sets its ctorParameters to an empty array which breaks ES6 usage (it should inject several things, seen in the CdkTable.

https://unpkg.com/@angular/[email protected]/esm2015/table.js

/** @nocollapse */
MatTable.ctorParameters = () => [];

Updating this version to fix this issue in the compiler for the next time we build. Although, technically we fixed it ourselves by working around it with an explicitly set constructor angular/components#10982.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewseguin
build: update tsickle in main package.json
1eef53e
@mary-poppins

mary-poppins commented Apr 26, 2018

Copy link
Copy Markdown

You can preview 1eef53e at https://pr23531-1eef53e.ngbuilds.io/.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewseguin
andrewseguin force-pushed the compiler-cli-tsickle-update branch from 5f40aca to 1eef53e Compare May 1, 2018 17:34
@andrewseguin
andrewseguin requested a review from IgorMinar May 15, 2018 18:04
@ngbot

ngbot Bot commented May 16, 2018

Copy link
Copy Markdown

Hi @andrewseguin! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewseguin andrewseguin closed this May 16, 2018
@scott-ho

scott-ho commented May 21, 2018

Copy link
Copy Markdown

@andrewseguin why do you close the PR without further patches?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewseguin

andrewseguin commented May 21, 2018

Copy link
Copy Markdown
Contributor Author

@scott-ho This change was captured by another PR, #23782
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub Awaiting requested review from alxhub
@IgorMinar IgorMinar Awaiting requested review from IgorMinar

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@andrewseguin @mary-poppins @IgorMinar @scott-ho @googlebot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.