GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — build: upgrade to TypeScript 2.8 by LucasSloan · Pull Request #23782 · angular/angular

Conversation

LucasSloan commented May 8, 2018

Copy link

Copy Markdown

Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Builds with TS 2.7
Issue Number: #23092

What is the new behavior?

Builds with TS 2.8.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

LucasSloan requested a review from alxhub

May 8, 2018 23:40

googlebot added the cla: yes label

May 8, 2018

mary-poppins commented May 8, 2018

Copy link

Copy Markdown

You can preview 771289c at https://pr23782-771289c.ngbuilds.io/.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ghost commented May 9, 2018

Copy link

Copy Markdown

Shouldn't this title be build: upgrade to TypeScript 2.8?

gkalpak reacted with thumbs up emoji

sarunint, Bnaya, and nicolashenry reacted with laugh emoji

All reactions

👍 1 reaction
😄 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gkalpak changed the title ~~build: upgrade to TypeScript 2.7~~ build: upgrade to TypeScript 2.8

May 9, 2018

gkalpak commented May 9, 2018

Copy link

Copy Markdown

Member

Fixed the PR title, but the commit message has to be updated too 😁

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

LucasSloan force-pushed the ts28-upgrade branch from 771289c to 6cbbf34 Compare

May 9, 2018 17:47

LucasSloan commented May 9, 2018

Copy link

Copy Markdown

Contributor Author

Whoops, taken care of.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mary-poppins commented May 9, 2018

Copy link

Copy Markdown

You can preview 6cbbf34 at https://pr23782-6cbbf34.ngbuilds.io/.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

LucasSloan force-pushed the ts28-upgrade branch from 6cbbf34 to ea4e2b4 Compare

May 9, 2018 18:34

mary-poppins commented May 9, 2018

Copy link

Copy Markdown

You can preview ea4e2b4 at https://pr23782-ea4e2b4.ngbuilds.io/.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

LucasSloan force-pushed the ts28-upgrade branch from ea4e2b4 to b6075a7 Compare

May 14, 2018 16:23

mary-poppins commented May 14, 2018

Copy link

Copy Markdown

You can preview b6075a7 at https://pr23782-b6075a7.ngbuilds.io/.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alxhub approved these changes

May 14, 2018

View reviewed changes

Comment thread

integration/typings_test_ts28/package.json Outdated

alxhub May 14, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this should say Typescript 2.8?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

LucasSloan May 14, 2018

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds right. I've also gone back and updated the test for 2.7 to say 2.7, not 2.6.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

LucasSloan force-pushed the ts28-upgrade branch from b6075a7 to e346628 Compare

May 14, 2018 17:58

mary-poppins commented May 14, 2018

Copy link

Copy Markdown

You can preview e346628 at https://pr23782-e346628.ngbuilds.io/.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

LucasSloan requested a review from IgorMinar

May 14, 2018 19:11

rafaelss95 reviewed

May 14, 2018

View reviewed changes

Comment thread

integration/typings_test_ts28/tsconfig.json Outdated

rafaelss95 May 14, 2018

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

28?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

LucasSloan May 15, 2018

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          build: upgrade to TypeScript 2.8

0f3e647

LucasSloan force-pushed the ts28-upgrade branch from e346628 to 0f3e647 Compare

May 15, 2018 17:10

alxhub added the target: major This PR is targeted for the next major release label

May 15, 2018

mary-poppins commented May 15, 2018

Copy link

Copy Markdown

You can preview 0f3e647 at https://pr23782-0f3e647.ngbuilds.io/.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

IgorMinar approved these changes

May 15, 2018

View reviewed changes

IgorMinar left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was actually a pretty smooth update! Thanks Lucas!

Can you please presubmit this with g3sync presubmit 23782 (see go/angular-g3sync). Thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

IgorMinar added the action: merge The PR is ready for merge by the caretaker label

May 15, 2018

IgorMinar commented May 15, 2018

Copy link

Copy Markdown

Contributor

Lucas, I'm labeling this with merge, but we still need g3 presubmit before the caretaker will merge this. As soon as that's done, the change will be picked up by the caretaker and merged.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

LucasSloan commented May 15, 2018

Copy link

Copy Markdown

Contributor Author

Running now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alxhub closed this in

5cf82f8

May 15, 2018

andrewseguin mentioned this pull request

May 21, 2018

build(compiler-cli): update tsickle version #23531

Closed

1 of 3 tasks

mashhoodr pushed a commit to mashhoodr/angular that referenced this pull request

May 28, 2018


          build: upgrade to TypeScript 2.8 (angular#23782)

bb4dd15

PR Close angular#23782

sarunint mentioned this pull request

Jun 24, 2018

Add support for TypeScript 2.8 #23779

Closed

6 of 7 tasks

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link

Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators

Sep 13, 2019

Reviewers

alxhub

alxhub approved these changes

+2 more reviewers

rafaelss95

rafaelss95 left review comments

IgorMinar

IgorMinar approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge

The PR is ready for merge by the caretaker

cla: yes target: major

This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.