GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(common): format fractional seconds by vicb · Pull Request #24844 · angular/angular

Conversation

@vicb

@vicb vicb commented Jul 11, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

fix a bug introduced in #24831

formatDate(3001, 'm:ss.SSS', 'en') was incorrectly returning 3.100

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vicb vicb added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release labels Jul 11, 2018
@googlebot googlebot added the cla: yes label Jul 11, 2018
@vicb
vicb force-pushed the 0711-fixFormatDate branch from c88f07c to 0915e14 Compare July 11, 2018 16:00
@vicb
fix(common): format fractional seconds
edb088d 
fix a bug introduced in angular#24831
@vicb
vicb force-pushed the 0711-fixFormatDate branch from 0915e14 to edb088d Compare July 11, 2018 16:00
@vicb

vicb commented Jul 11, 2018

Copy link
Copy Markdown
Contributor Author

http://test/OCL:204134094:BASE:204134141:1531325216096:a3caf810
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mary-poppins

mary-poppins commented Jul 11, 2018

Copy link
Copy Markdown

You can preview edb088d at https://pr24844-edb088d.ngbuilds.io/.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ocombe
ocombe approved these changes Jul 11, 2018
View reviewed changes
@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 11, 2018
mhevery pushed a commit that referenced this pull request Jul 11, 2018
@vicb @mhevery
fix(common): format fractional seconds (#24844)
3c93d07 
fix a bug introduced in #24831

PR Close #24844
@mhevery mhevery closed this in 0b4d85e Jul 11, 2018
@vicb
vicb deleted the 0711-fixFormatDate branch August 3, 2018 19:08
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ocombe ocombe ocombe approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package cla: yes target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vicb @mary-poppins @ocombe @googlebot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.