GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [6.1.x] update angular.io to the new ServiceWorker by gkalpak · Pull Request #25997 · angular/angular

Conversation

@gkalpak

@gkalpak gkalpak commented Sep 18, 2018

Copy link
Copy Markdown
Member

This essentially backports #19795 to 6.1.x.
(Related: Jira FW-289)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gkalpak
gkalpak changed the base branch from master to 6.1.x September 18, 2018 12:16
@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer comp: docs-infra labels Sep 18, 2018
@googlebot

googlebot commented Sep 18, 2018

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@googlebot googlebot added the cla: no label Sep 18, 2018
@mary-poppins

mary-poppins commented Sep 18, 2018

Copy link
Copy Markdown

You can preview a95c21f at https://pr25997-a95c21f.ngbuilds.io/.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Sep 18, 2018
fix(docs-infra): configure Firebase to strip off the .html extension #25999
Closed
https://angular.io/guide/reactive-forms shows empty page #24973
Closed
@gkalpak

gkalpak commented Sep 20, 2018

Copy link
Copy Markdown
Member Author

Rebased on master and backported #25999.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gkalpak
gkalpak force-pushed the 6.1.x-build-aio-new-sw branch from a95c21f to bf84855 Compare September 20, 2018 08:48
@mary-poppins

mary-poppins commented Sep 20, 2018

Copy link
Copy Markdown

You can preview bf84855 at https://pr25997-bf84855.ngbuilds.io/.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gkalpak gkalpak mentioned this pull request Sep 20, 2018
angular.io website fail to search in firefox #26018
Closed
@gkalpak

gkalpak commented Sep 24, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

This should be updated to incorporate #26042 once that is released.
UPDATE: #26145 includes the fix from #26042 and should be backported into this PR once merged.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Sep 27, 2018
HTTP 503 in Chrome -- angular.io is currently unable to handle this request. #25834
Closed
build(docs_app): upgrade to latest SW and other fixes ReactiveX/rxjs#4201
Merged
@gkalpak gkalpak added the state: blocked label Oct 1, 2018
@gkalpak
gkalpak force-pushed the 6.1.x-build-aio-new-sw branch from bf84855 to 9824792 Compare October 1, 2018 17:41
@mary-poppins

mary-poppins commented Oct 1, 2018

Copy link
Copy Markdown

You can preview 9824792 at https://pr25997-9824792.ngbuilds.io/.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gkalpak

gkalpak commented Oct 1, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Backported #26145 into this PR.
This is now failing, because #26136 hasn't be backported to patch 😕
UPDATE: Merged now as 66c2d08.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alxhub and others added 10 commits October 1, 2018 23:25
@alxhub @gkalpak
feat(docs-infra): Convert AIO to use the new Service Worker 5.0.0.
a80fc96
AIO is currently using a beta version of @angular/service-worker.
Since that was implemented, the SW has been rewritten and released
as part of Angular 5.0.0. This commit updates AIO to use the latest
implementation, with an appropriate configuration file that caches
the various AIO assets in useful ways.
@gkalpak
refactor(docs-infra): remove unused images
62adffb
@gkalpak
refactor(docs-infra): move concept icons to more appropriate location
41922aa
@gkalpak
fix(docs-infra): correctly show icon for fetch error when offline
ccd0291
@gkalpak
build(docs-infra): enable ServiceWorker in cli config
7c6acc9
@gkalpak
build(docs-infra): remove the dependency on rxjs-compat
8993150
@gkalpak
build(docs-infra): remove unused dependencies
19fa9d2
@gkalpak
build(docs-infra): upgrade @angular/cli to 6.0.3
aaa4b9e
@gkalpak
build(docs-infra): upgrade @angular/* to 6.0.2 and rxjs to 6.1.0
2b20689
@gkalpak
build(docs-infra): upgrade @angular/material to 6.0.2
d8d7bf8
IgorMinar
IgorMinar approved these changes Oct 3, 2018
View reviewed changes
@IgorMinar IgorMinar added cla: yes and removed cla: no labels Oct 3, 2018
@googlebot

googlebot commented Oct 3, 2018

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Oct 3, 2018
alxhub added a commit that referenced this pull request Oct 3, 2018
@alxhub
feat(docs-infra): Convert AIO to use the new Service Worker 5.0.0. (#…
ad62eaa
…25997)

AIO is currently using a beta version of @angular/service-worker.
Since that was implemented, the SW has been rewritten and released
as part of Angular 5.0.0. This commit updates AIO to use the latest
implementation, with an appropriate configuration file that caches
the various AIO assets in useful ways.

PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
refactor(docs-infra): remove unused images (#25997)
31f352c
PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
refactor(docs-infra): move concept icons to more appropriate location (…
bc27b95
…#25997)

PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
fix(docs-infra): correctly show icon for fetch error when offline (#2…
00b3731
…5997)

PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
build(docs-infra): enable ServiceWorker in cli config (#25997)
5c84b91
PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
build(docs-infra): remove the dependency on rxjs-compat (#25997)
fefa171
PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
build(docs-infra): remove unused dependencies (#25997)
bc73dcb
PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
build(docs-infra): upgrade @angular/cli to 6.0.3 (#25997)
94b2673
PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
build(docs-infra): upgrade @angular/* to 6.0.2 and rxjs to 6.1.0 (#25997
8cbebc6
)

PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
build(docs-infra): upgrade @angular/material to 6.0.2 (#25997)
115c874
PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
build(docs-infra): upgrade @angular/cli to 6.1.0-rc.3 and @angular-de…
82fcb32
…vkit/build-angular to 0.7.0-rc.3 (#25997)

PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
build(docs-infra): upgrade @angular/* to 6.1.0-rc.3 and rxjs to 6.2.2 (…
7d45386
…#25997)

PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
build(docs-infra): downgrade @angular-devkit/build-angular to 0.6.7 (#…
a273491
…25997)

The is a bug in versions 0.6.8+ that breaks when trying to use Jasmine's
mock clock.

Related to angular/angular-cli#11626.

PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
fix(docs-infra): ignore server-side redirected URLs in the SW (#25997)
becb775
This allows URLs to be passed through to the server (where they are
properly redirected), instead of serving `index.html` from the SW.

Known issue:
`/docs/` will be passed through to the server. `/docs` (without the
trailing slash) will be correctly treated as a navigation URL and
handled by the SW.
We don't link to `/docs/` from within the app, but if there are external
links to `/docs/` they will require a round-trip to the server and will
not work in offline mode.

PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
build(docs-infra): update size limits (#25997)
a68c29d
PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
fix(docs-infra): configure Firebase to strip off the .html extension (
efde073
#25999) (#25997)

Firebase used to do it automatically (with `cleanUrls: true`), but it
stopped doing it unless the resulting URL corresponds to an existing
file (which is not always the case in angular.io; e.g. the resulting URL
might be matched by a new redirect rule).
This change in Firebase hosting behavior resulted in some URLs not being
correctly redirected (e.g. URLs to the archived v2 site, or `.html`
suffixed URLs from 3rd-party sites).

This commit fixes it, by configuring Firebase hosting to strip off the
`.html` extension and redirect (if no other redirect rule matched).

PR Close #25999

PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
build(docs-infra): update payload size limits to reflect current stat…
1975c0a
…us (#26145) (#25997)

PR Close #26145

PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
build(docs-infra): upgrade @angular/* to 7.0.0-beta.7 (#26145) (#25997)
fe0c5bf
PR Close #26145

PR Close #25997
alxhub pushed a commit that referenced this pull request Oct 3, 2018
@gkalpak @alxhub
build(docs-infra): upgrade @angular/cli to 6.2.3 (#26145) (#25997)
d815e41
PR Close #26145

PR Close #25997
@gkalpak

gkalpak commented Oct 3, 2018

Copy link
Copy Markdown
Member Author

This seems to have been merged. Closing...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gkalpak gkalpak closed this Oct 3, 2018
@gkalpak
gkalpak deleted the 6.1.x-build-aio-new-sw branch October 5, 2018 08:31
@petebacondarwin petebacondarwin mentioned this pull request Jan 23, 2019
rxjs.dev 503 error after browsing several pages ReactiveX/rxjs#4482
Closed
1 task done
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@IgorMinar IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@gkalpak @googlebot @mary-poppins @IgorMinar @alxhub
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.