GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(router): removed obsolete TODO comment by Maxim-Mazurok · Pull Request #29085 · angular/angular

Conversation

@Maxim-Mazurok

@Maxim-Mazurok Maxim-Mazurok commented Mar 3, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
  • (not applicable) Tests for the changes have been added (for bug fixes / features)
  • (not applicable) Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

comment exists

What is the new behavior?

comment removed

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Per discussin in #29082 (review) and #29082 (comment), this PR removing obsolete comment which was originally added by @IgorMinar in #22573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Maxim-Mazurok
fix(router): removed obsolete TODO comment
b3aea13
@Maxim-Mazurok
Maxim-Mazurok requested a review from a team March 3, 2019 19:01
@googlebot googlebot added the cla: yes label Mar 3, 2019
@brandonroberts brandonroberts added comp: docs effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR refactoring Issue that involves refactoring or code-cleanup labels Mar 4, 2019
@ngbot ngbot Bot added this to the Backlog milestone Mar 4, 2019
@brandonroberts brandonroberts self-assigned this Mar 4, 2019
@brandonroberts brandonroberts added area: router comp: docs/api labels Mar 4, 2019
brandonroberts
brandonroberts approved these changes Mar 5, 2019
View reviewed changes
@brandonroberts

brandonroberts commented Mar 5, 2019

Copy link
Copy Markdown
Contributor

Caretaker note: This is a docs only change and should not impact g3. Please run presubmit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 5, 2019
@ngbot ngbot Bot added the action: merge The PR is ready for merge by the caretaker label Mar 5, 2019
@AndrewKushnir AndrewKushnir closed this in 72ecc45 Mar 5, 2019
AndrewKushnir pushed a commit that referenced this pull request Mar 5, 2019
@Maxim-Mazurok @AndrewKushnir
fix(router): removed obsolete TODO comment (#29085)
2a25ac2 
PR Close #29085
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@brandonroberts brandonroberts brandonroberts approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandonroberts brandonroberts

Labels

action: merge The PR is ready for merge by the caretaker area: router cla: yes effort1: hours merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note refactoring Issue that involves refactoring or code-cleanup risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Maxim-Mazurok @brandonroberts @googlebot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.