GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — build: update to nodejs rules 0.41.0 by gregmagolan · Pull Request #33996 · angular/angular

Conversation

gregmagolan commented Nov 22, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

This brings is changes to the @nodejs repository required for #33927. See release notes for more details: https://github.com/bazelbuild/rules_nodejs/releases/tag/0.41.0.

rules_nodejs is approaching 1.0 and breaking changes for that release are being made more frequently. In this release, the ts_devserver API changed and it no longer injects html script tags into a provided index.html file. The diff on this commit is large as this breaking change affects quite a few tests.

Also note that we don’t update @angular/bazel schematics and integration/bazel as 0.41.0 is not a recommended update for angular end-users yet due to the breaking changes in ts_devserver & web_package (now named pkg_web). When a suitable plain npm package that is in progress is finished then it will be possible to easily replace the html injection functionality removed from ts_devserver & pkg_web.

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

googlebot added the cla: yes label

Nov 22, 2019

This was referenced Nov 24, 2019

fix: allow files in protractor data attribute bazel-contrib/rules_nodejs#1388

Merged

build: npm_integration_test && angular_integration_test #33927

Closed

gregmagolan requested a review from alexeagle

November 24, 2019 17:33

gregmagolan marked this pull request as ready for review

November 24, 2019 17:34

gregmagolan requested a review from IgorMinar as a code owner

November 24, 2019 17:34

gregmagolan requested review from a team

November 24, 2019 17:34

gregmagolan commented Nov 24, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

Note: protractor data work-around in this PR can be removed after this bazel-contrib/rules_nodejs#1388 lands and makes it into the next release.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gregmagolan added target: patch

This PR is targeted for the next patch release

area: bazel Issues related to the published `@angular/bazel` build rules labels

Nov 24, 2019

ngbot Bot added this to the needsTriage milestone

Nov 24, 2019

gregmagolan added the area: build & ci Related the build and CI infrastructure of the project label

Nov 24, 2019

petebacondarwin reviewed

Nov 25, 2019

View reviewed changes

Comment thread

modules/playground/e2e_test/sourcemap/BUILD.bazel Resolved

Uh oh!

There was an error while loading. Please reload this page.

petebacondarwin approved these changes

Nov 25, 2019

View reviewed changes

josephperrott approved these changes

Nov 25, 2019

View reviewed changes

josephperrott left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

modules/playground/src/web_workers/images/index.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

josephperrott approved these changes

Nov 25, 2019

View reviewed changes

josephperrott left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, global approval

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gregmagolan added 2 commits

November 25, 2019 13:55


          build: update to nodejs rules 0.41.0

ad51f19

This bring is changes to the @nodejs repository required for #33927. See release notes for more details: https://github.com/bazelbuild/rules_nodejs/releases/tag/0.41.0.

rules_nodejs is approaching 1.0 and breaking changes for that release are being made more frequently. In this release, the ts_devserver API changed and it no longer injects html script tags into a provided index.html file. The diff on this commit is large as this breaking change affects quite a few tests.

Also note that we don’t update @angular/bazel schematics and integration/bazel as 0.41.0 is not a recommended update for angular users yet due to the breaking changes in ts_devserver & web_package (now named pkg_web). When a suitable plain npm package that is in progress is finished then it will be possible to easily replace the html injection functionality removed from ts_devserver & pkg_web.


          build: set default ts_devserver serving_path to /app_bundle.js to mat…

9e63b3d

…ch g3

alexeagle added the action: merge The PR is ready for merge by the caretaker label

Nov 26, 2019

josephperrott added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label

Nov 26, 2019

josephperrott commented Nov 26, 2019

Copy link

Copy Markdown

Member

Caretaker note: Global Approval

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mhevery pushed a commit that referenced this pull request

Nov 27, 2019


          build: update to nodejs rules 0.41.0 (#33996)

9255dc3

This bring is changes to the @nodejs repository required for #33927. See release notes for more details: https://github.com/bazelbuild/rules_nodejs/releases/tag/0.41.0.

rules_nodejs is approaching 1.0 and breaking changes for that release are being made more frequently. In this release, the ts_devserver API changed and it no longer injects html script tags into a provided index.html file. The diff on this commit is large as this breaking change affects quite a few tests.

Also note that we don’t update @angular/bazel schematics and integration/bazel as 0.41.0 is not a recommended update for angular users yet due to the breaking changes in ts_devserver & web_package (now named pkg_web). When a suitable plain npm package that is in progress is finished then it will be possible to easily replace the html injection functionality removed from ts_devserver & pkg_web.

PR Close #33996

mhevery pushed a commit that referenced this pull request

Nov 27, 2019


          build: set default ts_devserver serving_path to /app_bundle.js to mat…

1eddb1a

…ch g3 (#33996)

PR Close #33996

mhevery closed this in

c4335e2

Nov 27, 2019

mhevery pushed a commit that referenced this pull request

Nov 27, 2019


          build: set default ts_devserver serving_path to /app_bundle.js to mat…

005c4a1

…ch g3 (#33996)

PR Close #33996

angular-automatic-lock-bot Bot commented Dec 28, 2019

Copy link

Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators

Dec 28, 2019

Reviewers

josephperrott

josephperrott approved these changes

alexeagle

Awaiting requested review from alexeagle

IgorMinar

Awaiting requested review from IgorMinar

+1 more reviewer

petebacondarwin

petebacondarwin approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge

The PR is ready for merge by the caretaker

area: bazel

Issues related to the published `@angular/bazel` build rules

area: build & ci

Related the build and CI infrastructure of the project

cla: yes merge: caretaker note

Alert the caretaker performing the merge to check the PR for an out of normal action needed or note

target: patch

This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

gregmagolan commented Nov 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

gregmagolan commented Nov 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

josephperrott left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

josephperrott left a comment

Choose a reason for hiding this comment

Uh oh!

josephperrott commented Nov 26, 2019

Uh oh!

angular-automatic-lock-bot Bot commented Dec 28, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gregmagolan commented Nov 22, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

gregmagolan commented Nov 24, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.