GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — build: several minor fixes related to using `puppeteer` by gkalpak · Pull Request #35381 · angular/angular

Conversation

gkalpak commented Feb 12, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

This PR is a follow-up to #35049 and contains several fixes related to using the browser provided by puppeteer to run tests. It contains the following commits:

build: several minor fixes related to using puppeteer

This is a follow-up to #35049 with a few minor fixes related to using the browser provided by puppeteer to run tests. Included fixes:

Make the webdriver-manager-update.js really portable. (Previously,
it needed to be run from the directory that contained the
node_modules/ directory. Now, it can be executed from a subdirectory
and will correctly resolve dependencies.)
Use the puppeteer-based setup in AIO unit and e2e tests to ensure
that the downloaded ChromeDriver version matches the browser version
used in tests.
Use the puppeteer-based setup in the aio_monitoring_stable CI job
(as happens with aio_monitoring_next).
Use the recommended way of getting the browser port when using
puppeteer with lighthouse and avoid hard-coding the remote
debugging port (to be able to handle multiple instances running
concurrently).

build(docs-infra): use puppeteer to get a browser for docs examples tests

In #35049, integration and AIO tests were changed to use the browser provided by puppeteer in tests. This commit switches the docs examples tests to use the same setup.

IMPLEMENTATION NOTE:
The examples are used to create ZIP archives that docs users can download to experiment with. Since we want the downloaded projects to resemble an @angular/cli generated project, we do not want to affect the project's Protractor configuration in order to use puppeteer.

To achieve this, a second Protractor configuration is created (which is ignored when creating the ZIP archives) that extends the original one and passes the approperiate arguments to use the browser provided by puppeteer. This new configuration (protractor-puppeteer.conf.js) is used when running the docs examples tests (on CI or locally during development).

ci: get rid of the CI_CHROMEDRIVER_VERSION_ARG env var

Previously, we needed to manually specify a ChromeDriver version to download on CI that would be compatible with the browser version provided by the docker image used to run the tests. This was kept in the CI_CHROMEDRIVER_VERSION_ARG environment variable.

With recent commits, we use the browser provided by puppeteer and can determine the correct ChromeDriver version programmatically. Therefore, we no longer need the CI_CHROMEDRIVER_VERSION_ARG environment variable.

NOTE:
There is still one place (the bazel-schematics integration project) where a hard-coded ChromeDriver version is necessary. Since I am not sure what is the best way to refactor the tests to not rely on a hard-coded version, I left it as a TODO for a follow-up PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

googlebot added the cla: yes label

Feb 12, 2020

mary-poppins commented Feb 12, 2020

Copy link

Copy Markdown

You can preview 2a973b2 at https://pr35381-2a973b2.ngbuilds.io/.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gkalpak force-pushed the ci-aio-puppeteer branch from 2a973b2 to ccfcce9 Compare

February 12, 2020 17:04

mary-poppins commented Feb 12, 2020

Copy link

Copy Markdown

You can preview ccfcce9 at https://pr35381-ccfcce9.ngbuilds.io/.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gkalpak force-pushed the ci-aio-puppeteer branch from ccfcce9 to 6026d09 Compare

February 12, 2020 17:26

mary-poppins commented Feb 12, 2020

Copy link

Copy Markdown

You can preview 6026d09 at https://pr35381-6026d09.ngbuilds.io/.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gkalpak force-pushed the ci-aio-puppeteer branch from 6026d09 to 6302c41 Compare

February 12, 2020 17:49

mary-poppins commented Feb 12, 2020

Copy link

Copy Markdown

You can preview 6302c41 at https://pr35381-6302c41.ngbuilds.io/.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kara added the area: build & ci Related the build and CI infrastructure of the project label

Feb 13, 2020

ngbot Bot added this to the needsTriage milestone

Feb 13, 2020

gkalpak added 3 commits

February 13, 2020 16:46


          build: several minor fixes related to using puppeteer

f8726c3

This is a follow-up to angular#35049 with a few minor fixes related to using
the browser provided by `puppeteer` to run tests. Included fixes:

- Make the `webdriver-manager-update.js` really portable. (Previously,
  it needed to be run from the directory that contained the
  `node_modules/` directory. Now, it can be executed from a subdirectory
  and will correctly resolve dependencies.)

- Use the `puppeteer`-based setup in AIO unit and e2e tests to ensure
  that the downloaded ChromeDriver version matches the browser version
  used in tests.

- Use the `puppeteer`-based setup in the `aio_monitoring_stable` CI job
  (as happens with `aio_monitoring_next`).

- Use the [recommended way][1] of getting the browser port when using
  `puppeteer` with `lighthouse` and avoid hard-coding the remote
  debugging port (to be able to handle multiple instances running
  concurrently).

[1]: https://github.com/GoogleChrome/lighthouse/blame/51df179a0/docs/puppeteer.md#L49


          build(docs-infra): use puppeteer to get a browser for docs examples…

863b8e5

… tests

In angular#35049, integration and AIO tests were changed to use the browser
provided by `puppeteer` in tests. This commit switches the docs examples
tests to use the same setup.

IMPLEMENTATION NOTE:
The examples are used to create ZIP archives that docs users can
download to experiment with. Since we want the downloaded projects to
resemble an `@angular/cli` generated project, we do not want to affect
the project's Protractor configuration in order to use `puppeteer`.

To achieve this, a second Protractor configuration is created (which is
ignored when creating the ZIP archives) that extends the original one
and passes the approperiate arguments to use the browser provided by
`puppeteer`. This new configuration (`protractor-puppeteer.conf.js`) is
used when running the docs examples tests (on CI or locally during
development).


          ci: get rid of the CI_CHROMEDRIVER_VERSION_ARG env var

6dd6ffe

Previously, we needed to manually specify a ChromeDriver version to
download on CI that would be compatible with the browser version
provided by the docker image used to run the tests. This was kept in the
`CI_CHROMEDRIVER_VERSION_ARG` environment variable.

With recent commits, we use the browser provided by `puppeteer` and can
determine the correct ChromeDriver version programmatically. Therefore,
we no longer need the `CI_CHROMEDRIVER_VERSION_ARG` environment
variable.

NOTE:
There is still one place (the `bazel-schematics` integration project)
where a hard-coded ChromeDriver version is necessary. Since I am not
sure what is the best way to refactor the tests to not rely on a
hard-coded version, I left it as a TODO for a follow-up PR.

gkalpak force-pushed the ci-aio-puppeteer branch from 6302c41 to 6dd6ffe Compare

February 13, 2020 15:15

gkalpak changed the title ~~WIP - Use puppeteer in docs-infra~~ build: several minor fixes related to using puppeteer

Feb 13, 2020

gkalpak added comp: docs-infra target: patch

This PR is targeted for the next patch release

action: merge The PR is ready for merge by the caretaker labels

Feb 13, 2020

mary-poppins commented Feb 13, 2020

Copy link

Copy Markdown

You can preview 6dd6ffe at https://pr35381-6dd6ffe.ngbuilds.io/.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gregmagolan reviewed

Feb 13, 2020

View reviewed changes

Comment thread

.circleci/env.sh

		# `.circleci/config.yml`. See http://chromedriver.chromium.org/downloads for a list of versions.
		# This variable is intended to be passed as an arg to the `webdriver-manager update` command (e.g.
		# `"postinstall": "webdriver-manager update $CI_CHROMEDRIVER_VERSION_ARG"`).
		setPublicVar CI_CHROMEDRIVER_VERSION_ARG "--versions.chrome 79.0.3945.130";

gregmagolan Feb 13, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need this for one last test which is the integration/bazel-schematics. Once that is updated to puppeteer we can finally kill it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gregmagolan Feb 13, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh. I see you hard-coded it there instead 👍 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gregmagolan reviewed

Feb 13, 2020

View reviewed changes

Comment thread

aio/karma.conf.js

		},
		},
		browsers: [process.env['CI'] ? 'ChromeHeadlessNoSandbox' : 'Chrome'],
		browsers: ['ChromeHeadlessNoSandbox'],

gregmagolan Feb 13, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For local testing I suppose you're no relying on the browser popping up and if you need it you can always change this temporarily?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gkalpak Feb 13, 2020

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, exactly. I still needed to pass some flags for the puppeteer-provided Chrome to work locally (at least on Windows) and I realized we hardly ever need the browser. For debugging you can always open a browser and point it to the Karma URL (or change this config temporarily as you mentioned).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

josephperrott reacted with thumbs up emoji

All reactions

👍 1 reaction

gregmagolan reviewed

Feb 13, 2020

View reviewed changes

Comment thread

aio/scripts/audit-web-app.js

		args: ['--remote-debugging-port=9222']});
		flags.port = browser.port;
		const browser = await puppeteer.launch();
		flags.port = (new URL(browser.wsEndpoint())).port;

gregmagolan Feb 13, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

josephperrott reacted with thumbs up emoji

All reactions

👍 1 reaction

gregmagolan reviewed

Feb 13, 2020

View reviewed changes

Comment thread

scripts/webdriver-manager-update.js


		const isWindows = process.platform === 'win32';
		const result = spawnSync(`${process.cwd()}/node_modules/.bin/webdriver-manager${isWindows ? '.cmd' : ''}`, args, {stdio: 'inherit'});
		const result = spawnSync('yarn', args, {shell: true, stdio: 'inherit'});

gregmagolan Feb 13, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was avoiding yarn as in a follow up PR i'll run the aio build in npm_integration_test so under Bazel I want to ensure that the correct version of yarn is used. However, under Bazel I think yarn will be on the path and it will redirect to the Bazel provisioned yarn to be hermetic.

However, this may now be more an issue outside of Bazel now since we're relying on the root .yarnrc to use yarn 1.21.1 and in this context there will be no .yarnrc in the cwd. + @josephperrott 👀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gregmagolan Feb 13, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will end up using the locally installed yarn now which may be out of date

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gkalpak Feb 13, 2020

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yarn is clever enough to look at parent directories and find the closest .yarnrc (if any). So, it will use our vendored version regardless of the directory.

If this turns out to be a problem for bazel, we can use require.resolve() to find the relative path to the closest node_modules/ directory (but yarn was easier for now and from what I understand it might work in bazel too).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gregmagolan Feb 13, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true for .yarnrc as I had to sift through that code to get yarn_install to honor .yarnrc and the yarn-path. However, there is special treatment for the yarn-path setting as it is a start-up setting; it may only be used if it is in a .yarnrc in the cwd as otherwise you can get into infinite recursion situations. You may be right however but should verify that is the case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

josephperrott Feb 13, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that it picks up the version from .yarnrc as desired.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gregmagolan Feb 14, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @josephperrott

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gkalpak marked this pull request as ready for review

February 13, 2020 18:46

gregmagolan mentioned this pull request

Feb 14, 2020

build: npm_integration_test && angular_integration_test #33927

Closed

3 of 14 tasks

gregmagolan self-requested a review

February 16, 2020 17:46

gregmagolan approved these changes

Feb 16, 2020

View reviewed changes

gregmagolan left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will be some conflict with #33927 but this will probably land first tho so I'll handle the conflicts on rebase.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gregmagolan commented Feb 16, 2020

Copy link

Copy Markdown

Contributor

After #33927 and this land I should be able to run aio in an npm_integration_test :)

gkalpak reacted with eyes emoji

All reactions

👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gkalpak requested a review from josephperrott

February 17, 2020 12:49

josephperrott approved these changes

Feb 18, 2020

View reviewed changes

josephperrott left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

alxhub pushed a commit that referenced this pull request

Feb 18, 2020


          build: several minor fixes related to using puppeteer (#35381)

598b3ff

This is a follow-up to #35049 with a few minor fixes related to using
the browser provided by `puppeteer` to run tests. Included fixes:

- Make the `webdriver-manager-update.js` really portable. (Previously,
  it needed to be run from the directory that contained the
  `node_modules/` directory. Now, it can be executed from a subdirectory
  and will correctly resolve dependencies.)

- Use the `puppeteer`-based setup in AIO unit and e2e tests to ensure
  that the downloaded ChromeDriver version matches the browser version
  used in tests.

- Use the `puppeteer`-based setup in the `aio_monitoring_stable` CI job
  (as happens with `aio_monitoring_next`).

- Use the [recommended way][1] of getting the browser port when using
  `puppeteer` with `lighthouse` and avoid hard-coding the remote
  debugging port (to be able to handle multiple instances running
  concurrently).

[1]: https://github.com/GoogleChrome/lighthouse/blame/51df179a0/docs/puppeteer.md#L49

PR Close #35381

alxhub pushed a commit that referenced this pull request

Feb 18, 2020


          build(docs-infra): use puppeteer to get a browser for docs examples…

cf28373

… tests (#35381)

In #35049, integration and AIO tests were changed to use the browser
provided by `puppeteer` in tests. This commit switches the docs examples
tests to use the same setup.

IMPLEMENTATION NOTE:
The examples are used to create ZIP archives that docs users can
download to experiment with. Since we want the downloaded projects to
resemble an `@angular/cli` generated project, we do not want to affect
the project's Protractor configuration in order to use `puppeteer`.

To achieve this, a second Protractor configuration is created (which is
ignored when creating the ZIP archives) that extends the original one
and passes the approperiate arguments to use the browser provided by
`puppeteer`. This new configuration (`protractor-puppeteer.conf.js`) is
used when running the docs examples tests (on CI or locally during
development).

PR Close #35381

alxhub pushed a commit that referenced this pull request

Feb 18, 2020


          ci: get rid of the CI_CHROMEDRIVER_VERSION_ARG env var (#35381)

83d68b3

Previously, we needed to manually specify a ChromeDriver version to
download on CI that would be compatible with the browser version
provided by the docker image used to run the tests. This was kept in the
`CI_CHROMEDRIVER_VERSION_ARG` environment variable.

With recent commits, we use the browser provided by `puppeteer` and can
determine the correct ChromeDriver version programmatically. Therefore,
we no longer need the `CI_CHROMEDRIVER_VERSION_ARG` environment
variable.

NOTE:
There is still one place (the `bazel-schematics` integration project)
where a hard-coded ChromeDriver version is necessary. Since I am not
sure what is the best way to refactor the tests to not rely on a
hard-coded version, I left it as a TODO for a follow-up PR.

PR Close #35381

alxhub closed this in

ab8199f

Feb 18, 2020

alxhub pushed a commit that referenced this pull request

Feb 18, 2020


          build(docs-infra): use puppeteer to get a browser for docs examples…

bdfe71a

… tests (#35381)

In #35049, integration and AIO tests were changed to use the browser
provided by `puppeteer` in tests. This commit switches the docs examples
tests to use the same setup.

IMPLEMENTATION NOTE:
The examples are used to create ZIP archives that docs users can
download to experiment with. Since we want the downloaded projects to
resemble an `@angular/cli` generated project, we do not want to affect
the project's Protractor configuration in order to use `puppeteer`.

To achieve this, a second Protractor configuration is created (which is
ignored when creating the ZIP archives) that extends the original one
and passes the approperiate arguments to use the browser provided by
`puppeteer`. This new configuration (`protractor-puppeteer.conf.js`) is
used when running the docs examples tests (on CI or locally during
development).

PR Close #35381

alxhub pushed a commit that referenced this pull request

Feb 18, 2020


          ci: get rid of the CI_CHROMEDRIVER_VERSION_ARG env var (#35381)

Previously, we needed to manually specify a ChromeDriver version to
download on CI that would be compatible with the browser version
provided by the docker image used to run the tests. This was kept in the
`CI_CHROMEDRIVER_VERSION_ARG` environment variable.

With recent commits, we use the browser provided by `puppeteer` and can
determine the correct ChromeDriver version programmatically. Therefore,
we no longer need the `CI_CHROMEDRIVER_VERSION_ARG` environment
variable.

NOTE:
There is still one place (the `bazel-schematics` integration project)
where a hard-coded ChromeDriver version is necessary. Since I am not
sure what is the best way to refactor the tests to not rely on a
hard-coded version, I left it as a TODO for a follow-up PR.

PR Close #35381

gkalpak deleted the ci-aio-puppeteer branch

February 18, 2020 21:03

mhevery pushed a commit that referenced this pull request

Feb 24, 2020


          build: remove CI_CHROMEDIRVER_VERSION_ARG from integration/bazel-sche…

561d402

…matics (#33927)

This means we don't need the action_env. Borrowed from @gkalpak's changes in #35381.

PR Close #33927

mhevery pushed a commit that referenced this pull request

Feb 24, 2020


          build: remove CI_CHROMEDIRVER_VERSION_ARG from integration/bazel-sche…

9efd7af

…matics (#33927)

This means we don't need the action_env. Borrowed from @gkalpak's changes in #35381.

PR Close #33927

gkalpak mentioned this pull request

Mar 11, 2020

build(docs-infra): do not include CI-specific config in docs examples ZIP archives #36018

Closed

gkalpak added a commit to gkalpak/angular that referenced this pull request

Mar 16, 2020


          build(docs-infra): do not include CI-specific config in docs examples…

fd45beb

… ZIP archives

In angular#35381, a new Protractor config file was introduced in docs examples,
`protractor-puppeteer.conf.js`, that was only supposed to be used on CI
and not be shipped with the ZIP archives provided for users to download
and experiment with the docs examples locally.

The logic to ignore the `protractor-puppeteer.conf.js` file was
incorrect, resulting in the file being retained in some examples (e.g.
[universal][1]). The problem was not immediately obvious, because most
examples explicitly specify all `**/*.js` files as ignored, but for
other examples the file was retained in the ZIP archive.

This commit fixes the logic to ensure the file is excluded from all docs
examples ZIP archives.

[1]: https://v9.angular.io/generated/zips/universal/universal.zip

angular-automatic-lock-bot Bot commented Mar 20, 2020

Copy link

Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators

Mar 20, 2020

Reviewers

josephperrott

josephperrott approved these changes

+1 more reviewer

gregmagolan

gregmagolan approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge

The PR is ready for merge by the caretaker

area: build & ci

Related the build and CI infrastructure of the project

cla: yes target: patch

This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

gkalpak commented Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mary-poppins commented Feb 12, 2020

Uh oh!

mary-poppins commented Feb 12, 2020

Uh oh!

mary-poppins commented Feb 12, 2020

Uh oh!

mary-poppins commented Feb 12, 2020

Uh oh!

mary-poppins commented Feb 13, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gregmagolan Feb 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gregmagolan left a comment

Choose a reason for hiding this comment

Uh oh!

gregmagolan commented Feb 16, 2020

Uh oh!

josephperrott left a comment

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Mar 20, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gkalpak commented Feb 12, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

gregmagolan Feb 13, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.